[coreboot] Patch set updated for coreboot: ac9989f AMD Fam14 boards: dimmSpd.c: Set `iobase` to `SMBUS0_BASE_ADDRESS` instead of `0xB00`

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Wed Feb 20 11:23:23 CET 2013


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2453

-gerrit

commit ac9989f5c4a03a2a3e58ed880c7fb1a743f8ccd4
Author: Jens Rottmann <JRottmann at LiPPERTembedded.de>
Date:   Tue Feb 19 14:46:31 2013 +0100

    AMD Fam14 boards: dimmSpd.c: Set `iobase` to `SMBUS0_BASE_ADDRESS` instead of `0xB00`
    
    For AMD Inagua, the following two commits
    
        commit 01f7ab93359ae0fee5784d35effbcbe0b596df18
        Author: Kerry Sheh <shekairui at gmail.com>
        Date:   Thu Jan 19 13:18:36 2012 +0800
    
            Inagua: Synchronize AMD/inagua mainboard.
    
            Reviewed-on: http://review.coreboot.org/542
    
    and
    
        commit d91c9b7e3cb9fdaeb9399a21907996130f3120bb
        Author: efdesign98 <efdesign98 at gmail.com>
        Date:   Thu Sep 15 10:59:55 2011 -0600
    
            AMD Inagua platform updates
    
            Reviewed-on: http://review.coreboot.org/136
    
    replaced the constant `iobase` is set to by the define `SMBUS0_BASE_ADDRESS` from `OEM.h`.
    
    Do the same for AMD Persimmon, South Station, Union station and ASRock E350M1.
    
    Change-Id: If095cd9d9b28b118b4072c7c9d345bf620b774c9
    Signed-off-by: Jens Rottmann <JRottmann at LiPPERTembedded.de>
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/mainboard/amd/persimmon/dimmSpd.c     | 3 ++-
 src/mainboard/amd/south_station/dimmSpd.c | 3 ++-
 src/mainboard/amd/union_station/dimmSpd.c | 3 ++-
 src/mainboard/asrock/e350m1/dimmSpd.c     | 3 ++-
 4 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/mainboard/amd/persimmon/dimmSpd.c b/src/mainboard/amd/persimmon/dimmSpd.c
index 1343ae9..0d3eb2e 100644
--- a/src/mainboard/amd/persimmon/dimmSpd.c
+++ b/src/mainboard/amd/persimmon/dimmSpd.c
@@ -20,6 +20,7 @@
 #include "Porting.h"
 #include "AGESA.h"
 #include "amdlib.h"
+#include "OEM.h" /* SMBUS0_BASE_ADDRESS */
 
 AGESA_STATUS AmdMemoryReadSPD (UINT32 unused1, UINT32 unused2, AGESA_READ_SPD_PARAMS *info);
 #define DIMENSION(array)(sizeof (array)/ sizeof (array [0]))
@@ -157,7 +158,7 @@ AGESA_STATUS AmdMemoryReadSPD (UINT32 unused1, UINT32 unused2, AGESA_READ_SPD_PA
 
 	spdAddress = spdAddressLookup [info->SocketId] [info->MemChannelId] [info->DimmId];
 	if (spdAddress == 0) return AGESA_ERROR;
-	ioBase = 0xB00;
+	ioBase = SMBUS0_BASE_ADDRESS;
 	setupFch (ioBase);
 	return readspd (ioBase, spdAddress, (void *) info->Buffer, 128);
 }
diff --git a/src/mainboard/amd/south_station/dimmSpd.c b/src/mainboard/amd/south_station/dimmSpd.c
index 2bd27d6..ec945e6 100644
--- a/src/mainboard/amd/south_station/dimmSpd.c
+++ b/src/mainboard/amd/south_station/dimmSpd.c
@@ -20,6 +20,7 @@
 #include "Porting.h"
 #include "AGESA.h"
 #include "amdlib.h"
+#include "OEM.h" /* SMBUS0_BASE_ADDRESS */
 
 AGESA_STATUS AmdMemoryReadSPD (UINT32 unused1, UINT32 unused2, AGESA_READ_SPD_PARAMS *info);
 #define DIMENSION(array)(sizeof (array)/ sizeof (array [0]))
@@ -160,7 +161,7 @@ AGESA_STATUS AmdMemoryReadSPD (UINT32 unused1, UINT32 unused2, AGESA_READ_SPD_PA
 
    spdAddress = spdAddressLookup [info->SocketId] [info->MemChannelId] [info->DimmId];
    if (spdAddress == 0) return AGESA_ERROR;
-   ioBase = 0xB00;
+   ioBase = SMBUS0_BASE_ADDRESS;
    setupFch (ioBase);
    return readspd (ioBase, spdAddress, (void *) info->Buffer, 128);
    }
diff --git a/src/mainboard/amd/union_station/dimmSpd.c b/src/mainboard/amd/union_station/dimmSpd.c
index 2bd27d6..ec945e6 100644
--- a/src/mainboard/amd/union_station/dimmSpd.c
+++ b/src/mainboard/amd/union_station/dimmSpd.c
@@ -20,6 +20,7 @@
 #include "Porting.h"
 #include "AGESA.h"
 #include "amdlib.h"
+#include "OEM.h" /* SMBUS0_BASE_ADDRESS */
 
 AGESA_STATUS AmdMemoryReadSPD (UINT32 unused1, UINT32 unused2, AGESA_READ_SPD_PARAMS *info);
 #define DIMENSION(array)(sizeof (array)/ sizeof (array [0]))
@@ -160,7 +161,7 @@ AGESA_STATUS AmdMemoryReadSPD (UINT32 unused1, UINT32 unused2, AGESA_READ_SPD_PA
 
    spdAddress = spdAddressLookup [info->SocketId] [info->MemChannelId] [info->DimmId];
    if (spdAddress == 0) return AGESA_ERROR;
-   ioBase = 0xB00;
+   ioBase = SMBUS0_BASE_ADDRESS;
    setupFch (ioBase);
    return readspd (ioBase, spdAddress, (void *) info->Buffer, 128);
    }
diff --git a/src/mainboard/asrock/e350m1/dimmSpd.c b/src/mainboard/asrock/e350m1/dimmSpd.c
index 24e2617..62aedd2 100644
--- a/src/mainboard/asrock/e350m1/dimmSpd.c
+++ b/src/mainboard/asrock/e350m1/dimmSpd.c
@@ -20,6 +20,7 @@
 #include "Porting.h"
 #include "AGESA.h"
 #include "amdlib.h"
+#include "OEM.h" /* SMBUS0_BASE_ADDRESS */
 
 AGESA_STATUS AmdMemoryReadSPD (UINT32 unused1, UINT32 unused2, AGESA_READ_SPD_PARAMS *info);
 #define DIMENSION(array)(sizeof (array)/ sizeof (array [0]))
@@ -160,7 +161,7 @@ AGESA_STATUS AmdMemoryReadSPD (UINT32 unused1, UINT32 unused2, AGESA_READ_SPD_PA
 
    spdAddress = spdAddressLookup [info->SocketId] [info->MemChannelId] [info->DimmId];
    if (spdAddress == 0) return AGESA_ERROR;
-   ioBase = 0xB00;
+   ioBase = SMBUS0_BASE_ADDRESS;
    setupFch (ioBase);
    return readspd (ioBase, spdAddress, (void *) info->Buffer, 128);
    }



More information about the coreboot mailing list