[coreboot] New patch to review for coreboot: 63c39e6 libcbfs: Fix legacy CBFS API, typos

Hung-Te Lin (hungte@chromium.org) gerrit at coreboot.org
Wed Feb 20 08:45:35 CET 2013


Hung-Te Lin (hungte at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2457

-gerrit

commit 63c39e63d40a5a54ff91583cd6fad35cb0dedd7f
Author: Hung-Te Lin <hungte at chromium.org>
Date:   Wed Feb 20 15:43:47 2013 +0800

    libcbfs: Fix legacy CBFS API, typos
    
    Pulling CBFS fix from libpayload: http://review.coreboot.org/#/c/2455/2
    
    get_cbfs_header expects CBFS_HEADER_INVALID_ADDRESS (0xffffffff)
    instead of NULL when something is wrong.
    Also, fix typo.
    
    Change-Id: I7f393f7c24f74a3358f7339a3095b0d845bdc02d
    Signed-off-by: Hung-Te Lin <hungte at chromium.org>
---
 src/lib/cbfs_core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/lib/cbfs_core.c b/src/lib/cbfs_core.c
index da7bb6a..604d5f4 100644
--- a/src/lib/cbfs_core.c
+++ b/src/lib/cbfs_core.c
@@ -62,8 +62,8 @@ const struct cbfs_header *cbfs_get_header(struct cbfs_media *media)
 	if (media == CBFS_DEFAULT_MEDIA) {
 		media = &default_media;
 		if (init_default_cbfs_media(media) != 0) {
-			ERROR("Failed to initializee default media.\n");
-			return NULL;
+			ERROR("Failed to initialize default media.\n");
+			return CBFS_HEADER_INVALID_ADDRESS;
 		}
 	}
 
@@ -103,7 +103,7 @@ struct cbfs_file *cbfs_get_file(struct cbfs_media *media, const char *name)
 	if (media == CBFS_DEFAULT_MEDIA) {
 		media = &default_media;
 		if (init_default_cbfs_media(media) != 0) {
-			ERROR("Failed to initializee default media.\n");
+			ERROR("Failed to initialize default media.\n");
 			return NULL;
 		}
 	}



More information about the coreboot mailing list