[coreboot] New patch to review for coreboot: 4cf142e Persimmon: replace magic number with proper constant

Jens Rottmann (JRottmann@LiPPERTembedded.de) gerrit at coreboot.org
Tue Feb 19 14:57:03 CET 2013


Jens Rottmann (JRottmann at LiPPERTembedded.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2453

-gerrit

commit 4cf142ebe72a8a1093abced10cd8162663d7467d
Author: Jens Rottmann <JRottmann at LiPPERTembedded.de>
Date:   Tue Feb 19 14:46:31 2013 +0100

    Persimmon: replace magic number with proper constant
    
    Use SMBUS0_BASE_ADDRESS, exactly like on Inagua.
    
    Change-Id: If095cd9d9b28b118b4072c7c9d345bf620b774c9
    Signed-off-by: Jens Rottmann <JRottmann at LiPPERTembedded.de>
---
 src/mainboard/amd/persimmon/dimmSpd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/amd/persimmon/dimmSpd.c b/src/mainboard/amd/persimmon/dimmSpd.c
index 1343ae9..0d3eb2e 100644
--- a/src/mainboard/amd/persimmon/dimmSpd.c
+++ b/src/mainboard/amd/persimmon/dimmSpd.c
@@ -20,6 +20,7 @@
 #include "Porting.h"
 #include "AGESA.h"
 #include "amdlib.h"
+#include "OEM.h" /* SMBUS0_BASE_ADDRESS */
 
 AGESA_STATUS AmdMemoryReadSPD (UINT32 unused1, UINT32 unused2, AGESA_READ_SPD_PARAMS *info);
 #define DIMENSION(array)(sizeof (array)/ sizeof (array [0]))
@@ -157,7 +158,7 @@ AGESA_STATUS AmdMemoryReadSPD (UINT32 unused1, UINT32 unused2, AGESA_READ_SPD_PA
 
 	spdAddress = spdAddressLookup [info->SocketId] [info->MemChannelId] [info->DimmId];
 	if (spdAddress == 0) return AGESA_ERROR;
-	ioBase = 0xB00;
+	ioBase = SMBUS0_BASE_ADDRESS;
 	setupFch (ioBase);
 	return readspd (ioBase, spdAddress, (void *) info->Buffer, 128);
 }



More information about the coreboot mailing list