[coreboot] Patch merged into coreboot/master: 7b654a9 cbfstool: Fix compile warnings caused by incorrect data types.

gerrit at coreboot.org gerrit at coreboot.org
Mon Feb 18 12:28:47 CET 2013


the following patch was just integrated into master:
commit 7b654a9702640c2d9fb8c37e4ae7f6b27ca949a0
Author: Hung-Te Lin <hungte at chromium.org>
Date:   Mon Feb 18 18:35:00 2013 +0800

    cbfstool: Fix compile warnings caused by incorrect data types.
    
    The "offset" in cbfs-mkpayload should be printed as type %lu
    instead of %d as `gcc` rightfully warns about.
    
        gcc -g -Wall -D_7ZIP_ST -c -o /srv/filme/src/coreboot/util/cbfstool/cbfs-mkpayload.o cbfs-mkpayload.c
        cbfs-mkpayload.c: In function ‘parse_fv_to_payload’:
        cbfs-mkpayload.c:284:3: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘long unsigned int’ [-Wformat]
        cbfs-mkpayload.c:296:3: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘long unsigned int’ [-Wformat]
    
    This warning was introduced in the following commit.
    
        commit 4610247ef1744ccabbcc6bfc441a3583aa49f7b5
        Author: Patrick Georgi <patrick at georgi-clan.de>
        Date:   Sat Feb 9 13:26:19 2013 +0100
    
            cbfstool: Handle alignment in UEFI payloads
    
            Reviewed-on: http://review.coreboot.org/2334
    
    Change-Id: I50c26a314723d45fcc6ff9ae2f08266cb7969a12
    Signed-off-by: Hung-Te Lin <hungte at chromium.org>
    Reviewed-on: http://review.coreboot.org/2440
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Tested-by: build bot (Jenkins)

Build-Tested: build bot (Jenkins) at Mon Feb 18 12:02:35 2013, giving +1
Reviewed-By: Paul Menzel <paulepanter at users.sourceforge.net> at Mon Feb 18 11:55:25 2013, giving +2
See http://review.coreboot.org/2440 for details.

-gerrit



More information about the coreboot mailing list