[coreboot] New patch to review for coreboot: a3ec4e7 libpayload: only compile drivers/serial.c on machines that use it.

Ronald G. Minnich (rminnich@gmail.com) gerrit at coreboot.org
Fri Feb 15 17:14:43 CET 2013

Ronald G. Minnich (rminnich at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2412


commit a3ec4e725ebee245539629373f707b6b4eb760dd
Author: Ronald G. Minnich <rminnich at gmail.com>
Date:   Fri Feb 15 08:13:29 2013 -0800

    libpayload: only compile drivers/serial.c on machines that use it.
    Create a new serial console variable, X86_SERIAL_CONSOLE
    which is only enabled when SERIAL_CONSOLE and ARCH_X86 are defined.
    Builds for x86 and ARM.
    Change-Id: I607253c418de015975a839e3c33577842885ec0c
    Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
 payloads/libpayload/Config.in            | 7 ++++++-
 payloads/libpayload/drivers/Makefile.inc | 2 +-
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/payloads/libpayload/Config.in b/payloads/libpayload/Config.in
index a14291d..0a6fbe8 100644
--- a/payloads/libpayload/Config.in
+++ b/payloads/libpayload/Config.in
@@ -168,9 +168,14 @@ config SERIAL_CONSOLE
 	bool "See output on the serial port console"
 	default y
+	bool
+	depends on ARCH_X86 && SERIAL_CONSOLE
+	default y
 	hex "I/O base for the serial port (default 0x3f8)"
-	depends on SERIAL_CONSOLE
+	depends on X86_SERIAL_CONSOLE
 	default 0x3f8
diff --git a/payloads/libpayload/drivers/Makefile.inc b/payloads/libpayload/drivers/Makefile.inc
index e3bb995..60e0fab 100644
--- a/payloads/libpayload/drivers/Makefile.inc
+++ b/payloads/libpayload/drivers/Makefile.inc
@@ -33,7 +33,7 @@ libc-$(CONFIG_PCI) += pci.c
 libc-$(CONFIG_SPEAKER) += speaker.c
-libc-$(CONFIG_SERIAL_CONSOLE) += serial.c
+libc-$(CONFIG_X86_SERIAL_CONSOLE) += serial.c
 libc-$(CONFIG_PC_KEYBOARD) += keyboard.c

More information about the coreboot mailing list