[coreboot] Patch set updated for coreboot: aa665fe libpayload: only compile drivers/serial.c on machines that it works on

Ronald G. Minnich (rminnich@gmail.com) gerrit at coreboot.org
Fri Feb 15 00:12:59 CET 2013


Ronald G. Minnich (rminnich at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2396

-gerrit

commit aa665fe0e830bf8737ab3dd9c255fd309dbcc482
Author: Ronald G. Minnich <rminnich at gmail.com>
Date:   Thu Feb 14 14:50:10 2013 -0800

    libpayload: only compile drivers/serial.c on machines that it works on
    
    Create a new serial control variable, X86_SERIAL_CONSOLE (I think
    a better name is likely needed) which is only enabled when both
    SERIAL_CONSOLE and ARCH_X86 are defined.
    
    Builds for arm and x86 now. Not tested for Power PC; I think we
    need to decide what to do about that platform (later).
    
    Change-Id: If9cf7caecf0b9541ada906899058f4a3bb5c7737
    Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
---
 payloads/libpayload/Config.in            | 7 ++++++-
 payloads/libpayload/drivers/Makefile.inc | 2 +-
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/payloads/libpayload/Config.in b/payloads/libpayload/Config.in
index a14291d..7efbc2b 100644
--- a/payloads/libpayload/Config.in
+++ b/payloads/libpayload/Config.in
@@ -168,9 +168,14 @@ config SERIAL_CONSOLE
 	bool "See output on the serial port console"
 	default y
 
+config X86_SERIAL_CONSOLE
+	bool
+	depends on ARCH_X86 && SERIAL_CONSOLE
+	default y
+
 config SERIAL_IOBASE
 	hex "I/O base for the serial port (default 0x3f8)"
-	depends on SERIAL_CONSOLE
+	depends on ARCH_X86 && SERIAL_CONSOLE
 	default 0x3f8
 
 config SERIAL_SET_SPEED
diff --git a/payloads/libpayload/drivers/Makefile.inc b/payloads/libpayload/drivers/Makefile.inc
index e3bb995..60e0fab 100644
--- a/payloads/libpayload/drivers/Makefile.inc
+++ b/payloads/libpayload/drivers/Makefile.inc
@@ -33,7 +33,7 @@ libc-$(CONFIG_PCI) += pci.c
 
 libc-$(CONFIG_SPEAKER) += speaker.c
 
-libc-$(CONFIG_SERIAL_CONSOLE) += serial.c
+libc-$(CONFIG_X86_SERIAL_CONSOLE) += serial.c
 
 libc-$(CONFIG_PC_KEYBOARD) += keyboard.c
 



More information about the coreboot mailing list