[coreboot] New patch to review for coreboot: d1ab5c7 libpayload: Make the 'default serial address' menu item available only on X86

Ronald G. Minnich (rminnich@gmail.com) gerrit at coreboot.org
Thu Feb 14 19:09:55 CET 2013


Ronald G. Minnich (rminnich at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2388

-gerrit

commit d1ab5c7aa21cecd5db2531016c60c8e52714d8a2
Author: Ronald G. Minnich <rminnich at gmail.com>
Date:   Thu Feb 14 10:07:48 2013 -0800

    libpayload: Make the 'default serial address' menu item available only on X86
    
    PCs are lucky, they've had a default serial port for 30+ years, longer
    than most coreboot committers have walked the earth.
    
    ARMs are insane. There is no "standard" serial port address.
    If there were, the vendors would feel inclined to change it.
    ARMs must always inherit a serial port config from coreboot.
    Don't even bother asking.
    
    Change-Id: I6ecc3c78b8a1e1c20178c3cbf8b47c67ef76792f
    Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
---
 payloads/libpayload/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/payloads/libpayload/Config.in b/payloads/libpayload/Config.in
index a14291d..3a9dad7 100644
--- a/payloads/libpayload/Config.in
+++ b/payloads/libpayload/Config.in
@@ -170,7 +170,7 @@ config SERIAL_CONSOLE
 
 config SERIAL_IOBASE
 	hex "I/O base for the serial port (default 0x3f8)"
-	depends on SERIAL_CONSOLE
+	depends on ARCH_X86 && SERIAL_CONSOLE
 	default 0x3f8
 
 config SERIAL_SET_SPEED



More information about the coreboot mailing list