[coreboot] New patch to review for coreboot: 6584cf6 snow: fix high_tables_base calculation

David Hendricks (dhendrix@chromium.org) gerrit at coreboot.org
Mon Feb 11 20:56:53 CET 2013


David Hendricks (dhendrix at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2355

-gerrit

commit 6584cf683e71fc12c5a87cff1102ff8c367850a5
Author: David Hendricks <dhendrix at chromium.org>
Date:   Mon Feb 11 11:53:42 2013 -0800

    snow: fix high_tables_base calculation
    
    It was off by a few orders of magnitude. D'oh.
    
    Change-Id: I9c8a3d5bd9ce261f914cfc7d05d86a1c61519b81
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
---
 src/mainboard/google/snow/ramstage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mainboard/google/snow/ramstage.c b/src/mainboard/google/snow/ramstage.c
index b779999..a3e9236 100644
--- a/src/mainboard/google/snow/ramstage.c
+++ b/src/mainboard/google/snow/ramstage.c
@@ -33,7 +33,7 @@ void main(void)
 	/* place at top of physical memory */
 	high_tables_size = CONFIG_COREBOOT_TABLES_SIZE;
 	high_tables_base = CONFIG_SYS_SDRAM_BASE +
-			((CONFIG_DRAM_SIZE_MB * 1024) * CONFIG_NR_DRAM_BANKS) -
+			((CONFIG_DRAM_SIZE_MB << 20UL) * CONFIG_NR_DRAM_BANKS) -
 			CONFIG_COREBOOT_TABLES_SIZE;
 #endif
 



More information about the coreboot mailing list