[coreboot] Patch merged into coreboot/master: 408aefd cbfstool: Fix crash on image without bootblock in end of ROM.

gerrit at coreboot.org gerrit at coreboot.org
Sat Feb 9 06:30:11 CET 2013

the following patch was just integrated into master:
commit 408aefd17645a95a0b1cac23b0ca7ad9c9df6925
Author: Hung-Te Lin <hungte at chromium.org>
Date:   Sat Feb 9 10:38:55 2013 +0800

    cbfstool: Fix crash on image without bootblock in end of ROM.
    On platforms with CBFS data filling end of ROM image without bootblock in the
    end (ex, ARM), calculation of "next valid entry" may exceed ROM image buffer in
    memory and raise segmentation fault when we try to compare its magic value.
    To fix this, always check if the entry address is inside ROM image buffer.
    Verified to build and boot successfully on qemu/x86 and armv7/snow.
    Change-Id: I117d6767a5403be636eea2b23be1dcf2e1c88839
    Signed-off-by: Hung-Te Lin <hungte at chromium.org>
    Reviewed-on: http://review.coreboot.org/2330
    Tested-by: build bot (Jenkins)
    Reviewed-by: David Hendricks <dhendrix at chromium.org>

Build-Tested: build bot (Jenkins) at Sat Feb  9 04:11:31 2013, giving +1
Reviewed-By: David Hendricks <dhendrix at chromium.org> at Sat Feb  9 04:14:34 2013, giving +2
See http://review.coreboot.org/2330 for details.


More information about the coreboot mailing list