[coreboot] Patch set updated for coreboot: b115b35 armv7: Clean up: remove deprecated SPL.

David Hendricks dhendrix at google.com
Thu Feb 7 01:04:59 CET 2013


On Wed, Feb 6, 2013 at 3:01 PM, Peter Stuge <peter at stuge.se> wrote:

> David Hendricks wrote:
> > David Hendricks (dhendrix at chromium.org) just uploaded a new patch set
> to gerrit, which you can find at http://review.coreboot.org/2297
> >
> > -gerrit
> >
> > commit b115b35c581af7892739afd7c4aaf2250e260f51
> > Author: Hung-Te Lin <hungte at chromium.org>
> > Date:   Wed Feb 6 17:48:20 2013 +0800
> >
> >     armv7: Clean up: remove deprecated SPL.
> >
> >     "SPL" from U-Boot is deprecated by bootblock in coreboot/arm, so we
> don't need
> >     it anymore.
>
> ..
>
> > diff --git a/src/cpu/samsung/exynos5250/power.c
> b/src/cpu/samsung/exynos5250/power.c
> > index 7c61655..60003c4 100644
> > --- a/src/cpu/samsung/exynos5250/power.c
> > +++ b/src/cpu/samsung/exynos5250/power.c
> > @@ -23,12 +23,12 @@
> >   */
> >
> >  #include <common.h>
> > +#include <arch/hlt.h>
> >  #include <arch/io.h>
> >  #include <console/console.h>
> >  #include <cpu/samsung/exynos5250/cpu.h>
> >  #include <cpu/samsung/exynos5250/power.h>
> >  #include <cpu/samsung/exynos5250/sysreg.h>
> > -#include <cpu/samsung/exynos5-common/spl.h>
> >  #include <drivers/maxim/max77686/max77686.h>
> >
> >  #include "device/i2c.h"
> > @@ -62,7 +62,7 @@ void power_shutdown(void)
> >
> >       clrbits_le32(&power->ps_hold_ctrl,
> POWER_PS_HOLD_CONTROL_DATA_HIGH);
> >
> > -     hang();
> > +     hlt();
> >  }
> >
> >  void power_enable_dp_phy(void)
>
> Most of the above hunk has nothing to do with this commit. It should
> of course have been part of the hang() removal commit but failing
> that at the very least put in a separate commit.
>

Yes and no... This hunk broke when the rest of this patch was applied
because it relied on a header which was included by another header which
was included by cpu/samsung/exynos5-common/spl.h. So the problem went
undetected until this patch was applied. This abysmal code architecture is
something we're trying to fix in the coreboot port.

-- 
David Hendricks (dhendrix)
Systems Software Engineer, Google Inc.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20130206/9a51c170/attachment.html>


More information about the coreboot mailing list