[coreboot] New patch to review for coreboot: 397d447 Use tabs instead of spaces to align comments in DSTD header

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Mon Feb 4 12:42:48 CET 2013


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2278

-gerrit

commit 397d44731f48ca93aa30bda676f703db2f9a4578
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Mon Feb 4 11:38:01 2013 +0100

    Use tabs instead of spaces to align comments in DSTD header
    
    AOpen DXPL Plus-U and Intel XE7501devkit use »COREBOOT« as
    OEM Table ID.
    
    Unify the DSDT by aligning the comments in the DSDT header with
    tabs in accordance with the coding style [1].
    
    [1] http://www.coreboot.org/Development_Guidelines#Coding_Style
    
    Change-Id: I78e6aa8d0318b519b1df5e2178d387dc58e48323
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/mainboard/aopen/dxplplusu/dsdt.asl    | 8 ++++----
 src/mainboard/intel/xe7501devkit/dsdt.asl | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/mainboard/aopen/dxplplusu/dsdt.asl b/src/mainboard/aopen/dxplplusu/dsdt.asl
index 095df06..b8bdde8 100644
--- a/src/mainboard/aopen/dxplplusu/dsdt.asl
+++ b/src/mainboard/aopen/dxplplusu/dsdt.asl
@@ -22,10 +22,10 @@
 DefinitionBlock(
 	"dsdt.aml",
 	"DSDT",
-	0x04,           // DSDT revision: ACPI v4.0
-	"COREv4",       // OEM id
-	"COREBOOT",     // OEM table id
-	0x20111103      // OEM revision
+	0x04,		// DSDT revision: ACPI v4.0
+	"COREv4",	// OEM id
+	"COREBOOT",	// OEM table id
+	0x20111103	// OEM revision
 ) {
 
 Scope(\_SB)
diff --git a/src/mainboard/intel/xe7501devkit/dsdt.asl b/src/mainboard/intel/xe7501devkit/dsdt.asl
index 360db88..87dd574 100644
--- a/src/mainboard/intel/xe7501devkit/dsdt.asl
+++ b/src/mainboard/intel/xe7501devkit/dsdt.asl
@@ -7,10 +7,10 @@
 DefinitionBlock(
 	"dsdt.aml",
 	"DSDT",
-	0x02,           // DSDT revision: ACPI v2.0
-	"COREv2",       // OEM id
-	"COREBOOT",     // OEM table id
-	0x20090419      // OEM revision
+	0x02,		// DSDT revision: ACPI v2.0
+	"COREv2",	// OEM id
+	"COREBOOT",	// OEM table id
+	0x20090419	// OEM revision
 )
 {
 }



More information about the coreboot mailing list