[coreboot] New patch to review for coreboot: ff82f2b Intel based boards: Use tab instead of spaces to align comment in DSDT

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Mon Feb 4 12:42:48 CET 2013


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2277

-gerrit

commit ff82f2b40c60ea635da0b83161c67aba0556d18b
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Mon Feb 4 10:31:34 2013 +0100

    Intel based boards: Use tab instead of spaces to align comment in DSDT
    
    Mainboards using `COREBOOT` as their OEM Table ID in their DSDT
    header were copied from the same source and therefore had spaces
    instead of a tab to align that comment for that header field. These
    are mostly Intel based  boards.
    
    Fix that in accordance with the coding style [1].
    
    [1] http://www.coreboot.org/Development_Guidelines#Coding_Style
    
    Change-Id: I299b955930dbd50b9717e8ff141ce8f3fd534e5f
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/mainboard/getac/p470/dsdt.asl         | 2 +-
 src/mainboard/google/parrot/dsdt.asl      | 2 +-
 src/mainboard/ibase/mb899/dsdt.asl        | 2 +-
 src/mainboard/intel/d945gclf/dsdt.asl     | 2 +-
 src/mainboard/intel/emeraldlake2/dsdt.asl | 2 +-
 src/mainboard/iwave/iWRainbowG6/dsdt.asl  | 2 +-
 src/mainboard/kontron/986lcd-m/dsdt.asl   | 2 +-
 src/mainboard/lenovo/t60/dsdt.asl         | 2 +-
 src/mainboard/lenovo/x60/dsdt.asl         | 2 +-
 src/mainboard/roda/rk886ex/dsdt.asl       | 2 +-
 src/mainboard/roda/rk9/dsdt.asl           | 2 +-
 src/mainboard/samsung/stumpy/dsdt.asl     | 2 +-
 12 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/src/mainboard/getac/p470/dsdt.asl b/src/mainboard/getac/p470/dsdt.asl
index baca3da..d89f75e 100644
--- a/src/mainboard/getac/p470/dsdt.asl
+++ b/src/mainboard/getac/p470/dsdt.asl
@@ -27,7 +27,7 @@ DefinitionBlock(
 	"DSDT",
 	0x02,		// DSDT revision: ACPI v2.0
 	"COREv4",	// OEM id
-	"COREBOOT",     // OEM table id
+	"COREBOOT",	// OEM table id
 	0x20090419	// OEM revision
 )
 {
diff --git a/src/mainboard/google/parrot/dsdt.asl b/src/mainboard/google/parrot/dsdt.asl
index 608827a..7aa633c 100644
--- a/src/mainboard/google/parrot/dsdt.asl
+++ b/src/mainboard/google/parrot/dsdt.asl
@@ -23,7 +23,7 @@ DefinitionBlock(
 	"DSDT",
 	0x02,		// DSDT revision: ACPI v2.0
 	"COREv4",	// OEM id
-	"COREBOOT",     // OEM table id
+	"COREBOOT",	// OEM table id
 	0x20110725	// OEM revision
 )
 {
diff --git a/src/mainboard/ibase/mb899/dsdt.asl b/src/mainboard/ibase/mb899/dsdt.asl
index 601c329..80d586a 100644
--- a/src/mainboard/ibase/mb899/dsdt.asl
+++ b/src/mainboard/ibase/mb899/dsdt.asl
@@ -22,7 +22,7 @@ DefinitionBlock(
 	"DSDT",
 	0x02,		// DSDT revision: ACPI v2.0
 	"COREv2",	// OEM id
-	"COREBOOT",     // OEM table id
+	"COREBOOT",	// OEM table id
 	0x20090419	// OEM revision
 )
 {
diff --git a/src/mainboard/intel/d945gclf/dsdt.asl b/src/mainboard/intel/d945gclf/dsdt.asl
index 62fa0af..dd1f3a1 100644
--- a/src/mainboard/intel/d945gclf/dsdt.asl
+++ b/src/mainboard/intel/d945gclf/dsdt.asl
@@ -22,7 +22,7 @@ DefinitionBlock(
 	"DSDT",
 	0x02,		// DSDT revision: ACPI v2.0
 	"COREv4",	// OEM id
-	"COREBOOT",     // OEM table id
+	"COREBOOT",	// OEM table id
 	0x20090419	// OEM revision
 )
 {
diff --git a/src/mainboard/intel/emeraldlake2/dsdt.asl b/src/mainboard/intel/emeraldlake2/dsdt.asl
index b67082e..cbac763 100644
--- a/src/mainboard/intel/emeraldlake2/dsdt.asl
+++ b/src/mainboard/intel/emeraldlake2/dsdt.asl
@@ -23,7 +23,7 @@ DefinitionBlock(
 	"DSDT",
 	0x02,		// DSDT revision: ACPI v2.0
 	"COREv4",	// OEM id
-	"COREBOOT",     // OEM table id
+	"COREBOOT",	// OEM table id
 	0x20110725	// OEM revision
 )
 {
diff --git a/src/mainboard/iwave/iWRainbowG6/dsdt.asl b/src/mainboard/iwave/iWRainbowG6/dsdt.asl
index 5bf59a7..6b95127 100644
--- a/src/mainboard/iwave/iWRainbowG6/dsdt.asl
+++ b/src/mainboard/iwave/iWRainbowG6/dsdt.asl
@@ -22,7 +22,7 @@ DefinitionBlock(
 	"DSDT",
 	0x02,		// DSDT revision: ACPI v2.0
 	"COREv2",	// OEM id
-	"COREBOOT",     // OEM table id
+	"COREBOOT",	// OEM table id
 	0x20090419	// OEM revision
 )
 {
diff --git a/src/mainboard/kontron/986lcd-m/dsdt.asl b/src/mainboard/kontron/986lcd-m/dsdt.asl
index a32015f..4e455cc 100644
--- a/src/mainboard/kontron/986lcd-m/dsdt.asl
+++ b/src/mainboard/kontron/986lcd-m/dsdt.asl
@@ -22,7 +22,7 @@ DefinitionBlock(
 	"DSDT",
 	0x02,		// DSDT revision: ACPI v2.0
 	"COREv4",	// OEM id
-	"COREBOOT",     // OEM table id
+	"COREBOOT",	// OEM table id
 	0x20090419	// OEM revision
 )
 {
diff --git a/src/mainboard/lenovo/t60/dsdt.asl b/src/mainboard/lenovo/t60/dsdt.asl
index 52a5edb..f32a220 100644
--- a/src/mainboard/lenovo/t60/dsdt.asl
+++ b/src/mainboard/lenovo/t60/dsdt.asl
@@ -24,7 +24,7 @@ DefinitionBlock(
 	"DSDT",
 	0x03,		// DSDT revision: ACPI v3.0
 	"COREv4",	// OEM id
-	"COREBOOT",     // OEM table id
+	"COREBOOT",	// OEM table id
 	0x20090419	// OEM revision
 )
 {
diff --git a/src/mainboard/lenovo/x60/dsdt.asl b/src/mainboard/lenovo/x60/dsdt.asl
index 52a5edb..f32a220 100644
--- a/src/mainboard/lenovo/x60/dsdt.asl
+++ b/src/mainboard/lenovo/x60/dsdt.asl
@@ -24,7 +24,7 @@ DefinitionBlock(
 	"DSDT",
 	0x03,		// DSDT revision: ACPI v3.0
 	"COREv4",	// OEM id
-	"COREBOOT",     // OEM table id
+	"COREBOOT",	// OEM table id
 	0x20090419	// OEM revision
 )
 {
diff --git a/src/mainboard/roda/rk886ex/dsdt.asl b/src/mainboard/roda/rk886ex/dsdt.asl
index 58e78ec..43d1609 100644
--- a/src/mainboard/roda/rk886ex/dsdt.asl
+++ b/src/mainboard/roda/rk886ex/dsdt.asl
@@ -24,7 +24,7 @@ DefinitionBlock(
 	"DSDT",
 	0x03,		// DSDT revision: ACPI v3.0
 	"COREv4",	// OEM id
-	"COREBOOT",     // OEM table id
+	"COREBOOT",	// OEM table id
 	0x20090419	// OEM revision
 )
 {
diff --git a/src/mainboard/roda/rk9/dsdt.asl b/src/mainboard/roda/rk9/dsdt.asl
index a240b17..cd6fd92 100644
--- a/src/mainboard/roda/rk9/dsdt.asl
+++ b/src/mainboard/roda/rk9/dsdt.asl
@@ -24,7 +24,7 @@ DefinitionBlock(
 	"DSDT",
 	0x03,		// DSDT revision: ACPI v3.0
 	"COREv4",	// OEM id
-	"COREBOOT",     // OEM table id
+	"COREBOOT",	// OEM table id
 	0x20090419	// OEM revision
 )
 {
diff --git a/src/mainboard/samsung/stumpy/dsdt.asl b/src/mainboard/samsung/stumpy/dsdt.asl
index 608827a..7aa633c 100644
--- a/src/mainboard/samsung/stumpy/dsdt.asl
+++ b/src/mainboard/samsung/stumpy/dsdt.asl
@@ -23,7 +23,7 @@ DefinitionBlock(
 	"DSDT",
 	0x02,		// DSDT revision: ACPI v2.0
 	"COREv4",	// OEM id
-	"COREBOOT",     // OEM table id
+	"COREBOOT",	// OEM table id
 	0x20110725	// OEM revision
 )
 {



More information about the coreboot mailing list