[coreboot] Integrating FILO with Coreboot

Peter Stuge peter at stuge.se
Mon Aug 19 11:59:20 CEST 2013


Hi Zoran,

Stojsavljevic, Zoran wrote:
> And then I got the following errors (end of compilation):
> CC      build/fs/fsys_reiserfs.o
>   CC      build/fs/fsys_iso9660.o
>   CC      build/fs/fsys_cbfs.o
> /home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/fs/fsys_cbfs.c: In function 'cbfs_dir':
> /home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/fs/fsys_cbfs.c:62:3: warning: implicit declaration of function 'be32toh' [-Wimplicit-function-declaration]
>   CC      build/drivers/ide_new.o
> /home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c: In function 'ob_ide_error':
> /home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:182:17: warning: variable 'old_cdb' set but not used [-Wunused-but-set-variable]
> /home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:162:16: warning: variable 'err' set but not used [-Wunused-but-set-variable]
> /home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c: In function 'ob_ide_atapi_packet':
> /home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:563:17: error: 'struct request_sense' has no member named 'sense_key'
> /home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:565:24: error: 'struct request_sense' has no member named 'sense_key'
> /home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c: In function 'ob_ide_atapi_drive_ready':
> /home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:679:2: warning: implicit declaration of function 'be32toh' [-Wimplicit-function-declaration]
> /home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:625:6: warning: unused variable 'i' [-Wunused-variable]
> /home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c: In function 'ob_ide_read_ata_chs':
> /home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:742:27: error: 'struct ata_sector' has no member named 'low'
> /home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:733:20: warning: variable 'ata_sector' set but not used [-Wunused-but-set-variable]
> /home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c: In function 'ob_ide_read_ata_lba48':
> /home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:795:27: error: 'struct ata_sector' has no member named 'low'
> /home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:796:27: error: 'struct ata_sector' has no member named 'high'
> /home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:784:20: warning: variable 'ata_sector' set but not used [-Wunused-but-set-variable]
> /home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c: In function 'ob_ide_fixup_id':
> /home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:887:2: warning: implicit declaration of function 'le16toh' [-Wimplicit-function-declaration]
> /home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:888:2: warning: implicit declaration of function 'le32toh' [-Wimplicit-function-declaration]
> /home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c: In function 'find_ide_controller':
> /home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:1279:19: warning: variable 'device' set but not used [-Wunused-but-set-variable]
> /home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:1279:11: warning: variable 'vendor' set but not used [-Wunused-but-set-variable]
> make: *** [/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/build/drivers/ide_new.o] Error 1
> 
> Any idea why this is happening?

I don't know about your environment but it seems to me that the FILO
code is buggy. It is not so popular anymore so it's possible that
there is some bitrot. Hopefully you can help look into what the
problem is.


> Did somehow I misconfigured coreboot/payloads/libpayload
> (it was compiled prior these steps)?

I'm not sure what you mean, but yes it has been possible to build
FILO in the past. If you can it would be great if you use git bisect
to find the commit which broke the build.


//Peter



More information about the coreboot mailing list