[coreboot] New patch to review for coreboot: cedbdcd lint: Get absolute path in compare_output

Zheng Bao (zheng.bao@amd.com) gerrit at coreboot.org
Fri Sep 28 12:28:49 CEST 2012

Zheng Bao (zheng.bao at amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1551


commit cedbdcdae7f045dc2b69da8b224298f70254db35
Author: Zheng Bao <fishbaozi at gmail.com>
Date:   Fri Sep 28 20:14:38 2012 +0800

    lint: Get absolute path in compare_output
    The classes in $(top)/Makefile uses $(abspath) to get the path.
    The $(abspath) can not resolve symlink. If the coreboot is located
    in a symlink directory, the run_printall produces the absolute
    path while the $PWD just produces the path with symlink. Use
    `pwd -P` to get the abs path.
    Change-Id: Icf6b364d030c14a9c78991767b17dafc701baf3c
    Signed-off-by: Zheng Bao <zheng.bao at amd.com>
    Signed-off-by: Zheng Bao <fishbaozi at gmail.com>
 util/lint/lint-stable-002-build-dir-handling | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/util/lint/lint-stable-002-build-dir-handling b/util/lint/lint-stable-002-build-dir-handling
index 9350907..ca61a35 100755
--- a/util/lint/lint-stable-002-build-dir-handling
+++ b/util/lint/lint-stable-002-build-dir-handling
@@ -58,7 +58,8 @@ rm -f $TMPCONFIG
 $MAKE DOTCONFIG=$TMPCONFIG allyesconfig >/dev/null
 # look up parent directory
-PARENTDIR=`dirname $PWD`
 compare_output "`run_printall build`" "build/.../static.c build/.../static.c build/.../static.ramstage.o build/.../static.romstage.o"
 compare_output "`run_printall ../obj`" "$PARENTDIR/obj/.../static.c $PARENTDIR/obj/.../static.c $PARENTDIR/obj/.../static.ramstage.o $PARENTDIR/obj/.../static.romstage.o"

More information about the coreboot mailing list