[coreboot] New patch to review for coreboot: 454ab9e nvramtool: uname in NetBSD doesnt take "-o"

Zheng Bao (zheng.bao@amd.com) gerrit at coreboot.org
Fri Sep 28 08:21:14 CEST 2012

Zheng Bao (zheng.bao at amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1545


commit 454ab9e057e49d4031bbe478b3cdcc1847edfda0
Author: Zheng Bao <fishbaozi at gmail.com>
Date:   Fri Sep 28 16:02:35 2012 +0800

    nvramtool: uname in NetBSD doesnt take "-o"
    see the Netbsd manual:
    Error output needs to be redirected.
    Change-Id: I1853a0162e14be0ee9d7971466499af6c72b2427
    Signed-off-by: Zheng Bao <zheng.bao at amd.com>
    Signed-off-by: Zheng Bao <fishbaozi at gmail.com>
 util/nvramtool/Makefile     | 2 +-
 util/nvramtool/Makefile.inc | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/util/nvramtool/Makefile b/util/nvramtool/Makefile
index 6723a48..fe2efa0 100644
--- a/util/nvramtool/Makefile
+++ b/util/nvramtool/Makefile
@@ -42,7 +42,7 @@ endif
 ifeq ($(OS_ARCH), NetBSD)
 LDFLAGS = -l$(shell uname -p)
-ifeq ($(shell uname -o), Cygwin)
+ifeq ($(shell uname -o 2>/dev/null), Cygwin)
 LDFLAGS = -lioperm
diff --git a/util/nvramtool/Makefile.inc b/util/nvramtool/Makefile.inc
index 67710da..8471b66 100644
--- a/util/nvramtool/Makefile.inc
+++ b/util/nvramtool/Makefile.inc
@@ -24,7 +24,7 @@ NVRAMTOOLFLAGS := -I$(top)/util/nvramtool
 ifeq ($(OS_ARCH), NetBSD)
 NVRAMTOOLLDLFLAGS = -l$(shell uname -p)
-ifeq ($(shell uname -o), Cygwin)
+ifeq ($(shell uname -o 2>/dev/null), Cygwin)
 NVRAMTOOLFLAGS += -O2 -g -Wall -W -D__GLIBC__

More information about the coreboot mailing list