[coreboot] New patch to review for coreboot: 855bb95 libpayload: fix fetching integers from CMOS as string

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Thu Sep 27 12:37:06 CEST 2012

Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1542


commit 855bb95ca1ca00957de044f9f4362c6cd054cf9a
Author: Patrick Georgi <patrick.georgi at secunet.com>
Date:   Wed Sep 26 15:11:48 2012 +0200

    libpayload: fix fetching integers from CMOS as string
    %ull -> %llu
    Change-Id: I330f681d713be7eb444870f81330cf6e9869a4fa
    Signed-off-by: Patrick Georgi <patrick.georgi at secunet.com>
 payloads/libpayload/drivers/options.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/payloads/libpayload/drivers/options.c b/payloads/libpayload/drivers/options.c
index 03b6d36..e2fd663 100644
--- a/payloads/libpayload/drivers/options.c
+++ b/payloads/libpayload/drivers/options.c
@@ -282,7 +282,7 @@ int get_option_as_string(const struct nvram_accessor *nvram, struct cb_cmos_opti
 			/* only works on little endian.
 			   26 bytes is enough for a 64bit value in decimal */
 			*dest = malloc(26);
-			sprintf(*dest, "%ull", *(u64*)raw);
+			sprintf(*dest, "%llu", *(u64*)raw);
 		case 's':
 			*dest = strdup(raw);

More information about the coreboot mailing list