[coreboot] New patch to review for coreboot: dcec334 Fix compilation without CONFIG_WRITE_HIGH_TABLES.
Denis Carikli (GNUtoo@no-log.org)
gerrit at coreboot.org
Sat Sep 22 14:57:14 CEST 2012
Denis Carikli (GNUtoo at no-log.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1533
-gerrit
commit dcec334895aa187e256543bc17382d567b3d1d94
Author: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
Date: Sat Sep 22 14:52:24 2012 +0200
Fix compilation without CONFIG_WRITE_HIGH_TABLES.
Without that fix we have:
CC boot/hardwaremain.ramstage.o
src/boot/hardwaremain.c: In function 'hardwaremain':
src/boot/hardwaremain.c:136:6: error: 'cbmem_post_handling' undeclared (first use in this function)
src/boot/hardwaremain.c:136:6: note: each undeclared identifier is reported only once for each function it appears in
src/boot/hardwaremain.c:137:3: error: implicit declaration of function 'cbmem_post_handling' [-Werror=implicit-function-declaration]
cc1: all warnings being treated as errors
make: *** [build/boot/hardwaremain.ramstage.o] Error 1
When compiling without CONFIG_WRITE_HIGH_TABLES
Change-Id: Ie45f684a6db0ab55ef469bfcef57e539ae7e994c
Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
---
src/boot/hardwaremain.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/boot/hardwaremain.c b/src/boot/hardwaremain.c
index bb7f264..099ab3a 100644
--- a/src/boot/hardwaremain.c
+++ b/src/boot/hardwaremain.c
@@ -133,8 +133,10 @@ void hardwaremain(int boot_complete)
timestamp_add(TS_DEVICE_DONE, timestamps[5]);
timestamp_add_now(TS_CBMEM_POST);
+#if CONFIG_WRITE_HIGH_TABLES
if (cbmem_post_handling)
cbmem_post_handling();
+#endif
timestamp_add_now(TS_WRITE_TABLES);
More information about the coreboot
mailing list