[coreboot] New patch to review for coreboot: 1325fcc UHCI: use proper pointer size

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Fri Sep 21 18:13:54 CEST 2012

Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1530


commit 1325fcc384a65a803c13aaaea50de46645d525e0
Author: Anton Kochkov <anton.kochkov at gmail.com>
Date:   Thu Sep 20 10:24:01 2012 +0200

    UHCI: use proper pointer size
    We used sizeof(listp*) at a place where sizeof(listp) is more appropriate:
    While these are pointers, they're part of the UHCI design, and don't depend
    on ISA details.
    Change-Id: I4d3cb571c9a407103bc81fc171a8e73b68f7c7a1
    Signed-off-by: Patrick Georgi <patrick.georgi at secunet.com>
 payloads/libpayload/drivers/usb/uhci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/payloads/libpayload/drivers/usb/uhci.c b/payloads/libpayload/drivers/usb/uhci.c
index 84b461a..635a8f1 100644
--- a/payloads/libpayload/drivers/usb/uhci.c
+++ b/payloads/libpayload/drivers/usb/uhci.c
@@ -175,7 +175,7 @@ uhci_init (pcidev_t addr)
 	reg16 &= 0xdf80;
 	pci_write_config16 (controller->bus_address, 0xc0, reg16);
-	UHCI_INST (controller)->framelistptr = memalign (0x1000, 1024 * sizeof (flistp_t *));	/* 4kb aligned to 4kb */
+	UHCI_INST (controller)->framelistptr = memalign (0x1000, 1024 * sizeof (flistp_t));	/* 4kb aligned to 4kb */
 	if (! UHCI_INST (controller)->framelistptr)
 		fatal("Not enough memory for USB frame list pointer.\n");

More information about the coreboot mailing list