[coreboot] Patch set updated for coreboot: dd52aa7 inteltool: remove bashism from Makefile

Stefan Tauner (stefan.tauner@gmx.at) gerrit at coreboot.org
Sun Oct 14 03:52:31 CEST 2012

Stefan Tauner (stefan.tauner at gmx.at) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1573


commit dd52aa7d313901269d9c5dfacad85022c3241168
Author: Stefan Tauner <stefan.tauner at gmx.at>
Date:   Sat Oct 13 02:33:35 2012 +0200

    inteltool: remove bashism from Makefile
    &> is a bashism to redirect both outward streams (stdout and stderr), but
    with other shells this introduces a race condition with the rm command
    after it, because the compiler execution is done in the background/
    in parallel. Found and tested with dash.
    Change-Id: I08516494828c9f7af168f954f2df027372657867
    Signed-off-by: Stefan Tauner <stefan.tauner at gmx.at>
 util/inteltool/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/inteltool/Makefile b/util/inteltool/Makefile
index d754005..af79b1e 100644
--- a/util/inteltool/Makefile
+++ b/util/inteltool/Makefile
@@ -59,7 +59,7 @@ pciutils:
 		   printf "struct pci_access *pacc;\n";		\
 		   printf "int main(int argc, char **argv)\n";	\
 		   printf "{ pacc = pci_alloc(); return 0; }\n"; ) > .test.c )
-	@$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) &>/dev/null &&	  \
+	@$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) >/dev/null 2>&1 &&	  \
 		printf "found.\n" || ( printf "not found.\n\n"; 	  \
 		printf "Please install pciutils-devel and zlib-devel.\n"; \
 		printf "See README for more information.\n\n";		  \

More information about the coreboot mailing list