[coreboot] Patch merged into coreboot/master: 0c2364c libpayload: Fix interrupt-queue cleanup for OHCI

gerrit at coreboot.org gerrit at coreboot.org
Sat Nov 24 08:54:04 CET 2012

the following patch was just integrated into master:
commit 0c2364c17ca40a4c726d98f3d2861d27ec02fed5
Author: Nico Huber <nico.huber at secunet.com>
Date:   Thu Nov 22 17:21:57 2012 +0100

    libpayload: Fix interrupt-queue cleanup for OHCI
    We have to free TDs more carefully if they have been processed by the
    controller yet. The current code tries to force the controller to post
    them back to the done queue, but that seems wrong. We can't be sure,
    when they get written back. This resulted in leaking TDs with an invalid
    reference to a freed interrupt queue.
    The new approach: Mark the interrupt queue to be destroyed and handle
    the freeing later, when the controller posted the last TD to the done
    Change-Id: I79d80a9dc89e1ca79dc125c4bbccbf23664227b3
    Signed-off-by: Nico Huber <nico.huber at secunet.com>
    Reviewed-on: http://review.coreboot.org/1905
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <patrick at georgi-clan.de>

Reviewed-By: Patrick Georgi <patrick at georgi-clan.de> at Sat Nov 24 08:54:03 2012, giving +2
See http://review.coreboot.org/1905 for details.


More information about the coreboot mailing list