[coreboot] New patch to review for coreboot: 844e497 libpayload: Fix some missing-prototype warnings

Nico Huber (nico.huber@secunet.com) gerrit at coreboot.org
Fri Nov 23 15:00:59 CET 2012


Nico Huber (nico.huber at secunet.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1894

-gerrit

commit 844e49782d0831c3ea9ae2bfaa3cf28a4e72f5f0
Author: Nico Huber <nico.huber at secunet.com>
Date:   Fri Nov 23 11:34:20 2012 +0100

    libpayload: Fix some missing-prototype warnings
    
    usb_controller_initialize() is not declared in any header file nor
    called from outside of usbinit.c, so make it static.
    
    set_configuration() looks like beeing non-static on purpose (like the
    other helpers around it in usb.c), so put a prototype into usb.h.
    
    Change-Id: I08d93b3769d8398bb43462d9afdfeec81fef93ec
    Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
 payloads/libpayload/drivers/usb/usbinit.c | 2 +-
 payloads/libpayload/include/usb/usb.h     | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/payloads/libpayload/drivers/usb/usbinit.c b/payloads/libpayload/drivers/usb/usbinit.c
index 4419ce6..f95e9c1 100644
--- a/payloads/libpayload/drivers/usb/usbinit.c
+++ b/payloads/libpayload/drivers/usb/usbinit.c
@@ -42,7 +42,7 @@
  * @param dev PCI device id at bus
  * @param func function id of the controller
  */
-int usb_controller_initialize(int bus, int dev, int func)
+static int usb_controller_initialize(int bus, int dev, int func)
 {
 	u32 class;
 	u32 devclass;
diff --git a/payloads/libpayload/include/usb/usb.h b/payloads/libpayload/include/usb/usb.h
index 8e286b4..d862182 100644
--- a/payloads/libpayload/include/usb/usb.h
+++ b/payloads/libpayload/include/usb/usb.h
@@ -230,6 +230,7 @@ void init_device_entry (hci_t *controller, int num);
 
 void set_feature (usbdev_t *dev, int endp, int feature, int rtype);
 void get_status (usbdev_t *dev, int endp, int rtype, int len, void *data);
+void set_configuration (usbdev_t *dev);
 int clear_feature (usbdev_t *dev, int endp, int feature, int rtype);
 int clear_stall (endpoint_t *ep);
 




More information about the coreboot mailing list