[coreboot] New patch to review for coreboot: 3314a3f libpayload: Do not call ohci_reset() from ohci_init()
Nico Huber (nico.huber@secunet.com)
gerrit at coreboot.org
Wed Nov 14 10:04:16 CET 2012
Nico Huber (nico.huber at secunet.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1850
-gerrit
commit 3314a3f49c1c635bc2d913789b679608e38e93f7
Author: Nico Huber <nico.huber at secunet.com>
Date: Mon Nov 12 16:19:21 2012 +0100
libpayload: Do not call ohci_reset() from ohci_init()
When ohci_reset() was implemented, OHCI controllers stopped working
since the stub ohci_reset() is called at the end of ohci_init().
This is fixed by removing the call. To prevent further problems the call
to the xhci_reset() stub is removed, too.
Change-Id: If89825c8e6caf40f7f4fe078e8b2e90054a54ba2
Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
payloads/libpayload/drivers/usb/ohci.c | 1 -
payloads/libpayload/drivers/usb/xhci.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/payloads/libpayload/drivers/usb/ohci.c b/payloads/libpayload/drivers/usb/ohci.c
index 095eec9..51af950 100644
--- a/payloads/libpayload/drivers/usb/ohci.c
+++ b/payloads/libpayload/drivers/usb/ohci.c
@@ -170,7 +170,6 @@ ohci_init (pcidev_t addr)
controller->devices[0]->controller = controller;
controller->devices[0]->init = ohci_rh_init;
controller->devices[0]->init (controller->devices[0]);
- ohci_reset (controller);
return controller;
}
diff --git a/payloads/libpayload/drivers/usb/xhci.c b/payloads/libpayload/drivers/usb/xhci.c
index f784686..d5ee134 100644
--- a/payloads/libpayload/drivers/usb/xhci.c
+++ b/payloads/libpayload/drivers/usb/xhci.c
@@ -195,7 +195,6 @@ xhci_init (pcidev_t addr)
controller->devices[0]->init = xhci_rh_init;
controller->devices[0]->init (controller->devices[0]);
- xhci_reset (controller);
return controller;
}
More information about the coreboot
mailing list