[coreboot] Patch merged into coreboot/master: 7f3d442 SMM: Avoid use of global variables in SMI handler

gerrit at coreboot.org gerrit at coreboot.org
Wed Nov 14 05:43:26 CET 2012

the following patch was just integrated into master:
commit 7f3d442abb2a8ff6f6728527ab7665fd79fd60cd
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Wed Oct 3 19:01:57 2012 -0700

    SMM: Avoid use of global variables in SMI handler
    Using global variables with the TSEG is a bad idea because
    they are not relocated properly right now.  Instead make
    the variables static and add accessor functions for the
    rest of SMM to use.
    At the same time drop the tcg/smi1 pointers as they are
    not setup or ever used.  (the debug output is added back
    in a subsequent commit)
    Change-Id: If0b2d47df4e482ead71bf713c1ef748da840073b
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: http://review.coreboot.org/1764
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>

Build-Tested: build bot (Jenkins) at Wed Nov 14 00:14:43 2012, giving +1
Reviewed-By: Ronald G. Minnich <rminnich at gmail.com> at Wed Nov 14 05:43:25 2012, giving +2
See http://review.coreboot.org/1764 for details.


More information about the coreboot mailing list