[coreboot] New patch to review for coreboot: a4f7ea1 Move HAVE_SMI_HANDLER from mainboards to chipsets

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Wed Nov 14 02:02:55 CET 2012


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1834

-gerrit

commit a4f7ea1e1e4b6a297737264adfb47c611506ee0c
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Tue Nov 13 13:01:31 2012 -0800

    Move HAVE_SMI_HANDLER from mainboards to chipsets
    
    Change-Id: Ibb6606fe3996e377181872a4544600f2d58c5439
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
---
 src/mainboard/asus/m2v-mx_se/Kconfig     |  3 ---
 src/mainboard/getac/p470/Kconfig         |  1 -
 src/mainboard/ibase/mb899/Kconfig        |  1 -
 src/mainboard/intel/d945gclf/Kconfig     |  1 -
 src/mainboard/intel/emeraldlake2/Kconfig |  1 -
 src/mainboard/iwave/iWRainbowG6/Kconfig  |  1 -
 src/mainboard/kontron/986lcd-m/Kconfig   |  1 -
 src/mainboard/lenovo/t60/Kconfig         |  1 -
 src/mainboard/lenovo/x60/Kconfig         |  1 -
 src/mainboard/rca/rm4100/Kconfig         |  1 -
 src/mainboard/roda/rk886ex/Kconfig       |  1 -
 src/mainboard/samsung/lumpy/Kconfig      |  1 -
 src/mainboard/samsung/stumpy/Kconfig     |  1 -
 src/mainboard/thomson/ip1000/Kconfig     |  1 -
 src/southbridge/intel/bd82x6x/Kconfig    |  1 +
 src/southbridge/intel/i82801dx/Kconfig   |  1 +
 src/southbridge/intel/i82801gx/Kconfig   |  1 +
 src/southbridge/intel/sch/Kconfig        |  1 +
 src/southbridge/via/vt8237r/Kconfig      | 12 ++++++++++--
 19 files changed, 14 insertions(+), 18 deletions(-)

diff --git a/src/mainboard/asus/m2v-mx_se/Kconfig b/src/mainboard/asus/m2v-mx_se/Kconfig
index de5511e..0ee9058 100644
--- a/src/mainboard/asus/m2v-mx_se/Kconfig
+++ b/src/mainboard/asus/m2v-mx_se/Kconfig
@@ -31,15 +31,12 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select SUPERIO_ITE_IT8712F
 	select HAVE_OPTION_TABLE
 	select HAVE_ACPI_TABLES
-	select HAVE_SMI_HANDLER
 	select BOARD_ROMSIZE_KB_512
 	select RAMINIT_SYSINFO
 	select VGA
 	select HAVE_ACPI_RESUME
 	select QRANK_DIMM_SUPPORT
 	select SET_FIDVID
-	# TODO test on multicore machines and enable if it works:
-	#select HAVE_SMI_HANDLER
 
 config MAINBOARD_DIR
 	string
diff --git a/src/mainboard/getac/p470/Kconfig b/src/mainboard/getac/p470/Kconfig
index d1c6f7f..dc08225 100644
--- a/src/mainboard/getac/p470/Kconfig
+++ b/src/mainboard/getac/p470/Kconfig
@@ -39,7 +39,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_ACPI_SLIC
 	select MMCONF_SUPPORT
 	select UDELAY_LAPIC
-	select HAVE_SMI_HANDLER
 	select BOARD_ROMSIZE_KB_1024
 	select GFXUMA
 	select CHANNEL_XOR_RANDOMIZATION
diff --git a/src/mainboard/ibase/mb899/Kconfig b/src/mainboard/ibase/mb899/Kconfig
index 28abf43..26f753b 100644
--- a/src/mainboard/ibase/mb899/Kconfig
+++ b/src/mainboard/ibase/mb899/Kconfig
@@ -16,7 +16,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_OPTION_TABLE
 	select HAVE_ACPI_RESUME
 	select MMCONF_SUPPORT
-	select HAVE_SMI_HANDLER
 	select BOARD_ROMSIZE_KB_512
 	select GFXUMA
 	select CHANNEL_XOR_RANDOMIZATION
diff --git a/src/mainboard/intel/d945gclf/Kconfig b/src/mainboard/intel/d945gclf/Kconfig
index 57078da..69f2380 100644
--- a/src/mainboard/intel/d945gclf/Kconfig
+++ b/src/mainboard/intel/d945gclf/Kconfig
@@ -37,7 +37,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_ACPI_TABLES
 	select HAVE_ACPI_RESUME
 	select MMCONF_SUPPORT
-	select HAVE_SMI_HANDLER
 	select BOARD_ROMSIZE_KB_512
 	select GFXUMA
 	select CHANNEL_XOR_RANDOMIZATION
diff --git a/src/mainboard/intel/emeraldlake2/Kconfig b/src/mainboard/intel/emeraldlake2/Kconfig
index aaca694..0644603 100644
--- a/src/mainboard/intel/emeraldlake2/Kconfig
+++ b/src/mainboard/intel/emeraldlake2/Kconfig
@@ -13,7 +13,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_OPTION_TABLE
 	select HAVE_ACPI_RESUME
 	select MMCONF_SUPPORT
-	select HAVE_SMI_HANDLER
 	select GFXUMA
 	#select CHROMEOS
 	select EXTERNAL_MRC_BLOB
diff --git a/src/mainboard/iwave/iWRainbowG6/Kconfig b/src/mainboard/iwave/iWRainbowG6/Kconfig
index d429a32..3d574b6 100644
--- a/src/mainboard/iwave/iWRainbowG6/Kconfig
+++ b/src/mainboard/iwave/iWRainbowG6/Kconfig
@@ -14,7 +14,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select USE_PRINTK_IN_CAR
 	select UDELAY_LAPIC
 	select HAVE_ACPI_TABLES
-	select HAVE_SMI_HANDLER
 	select BOARD_ROMSIZE_KB_1024
 	select GFXUMA
 
diff --git a/src/mainboard/kontron/986lcd-m/Kconfig b/src/mainboard/kontron/986lcd-m/Kconfig
index 49cc70e..99b6369 100644
--- a/src/mainboard/kontron/986lcd-m/Kconfig
+++ b/src/mainboard/kontron/986lcd-m/Kconfig
@@ -16,7 +16,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_OPTION_TABLE
 	select HAVE_ACPI_RESUME
 	select MMCONF_SUPPORT
-	select HAVE_SMI_HANDLER
 	select BOARD_ROMSIZE_KB_1024
 	select GFXUMA
 	select CHANNEL_XOR_RANDOMIZATION
diff --git a/src/mainboard/lenovo/t60/Kconfig b/src/mainboard/lenovo/t60/Kconfig
index 062a459..630f805 100644
--- a/src/mainboard/lenovo/t60/Kconfig
+++ b/src/mainboard/lenovo/t60/Kconfig
@@ -21,7 +21,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select GFXUMA
 	select BOARD_ROMSIZE_KB_2048
 	select CHANNEL_XOR_RANDOMIZATION
-	select HAVE_SMI_HANDLER
 	select HAVE_ACPI_TABLES
 	select HAVE_ACPI_RESUME
 config MAINBOARD_DIR
diff --git a/src/mainboard/lenovo/x60/Kconfig b/src/mainboard/lenovo/x60/Kconfig
index e77fac6..653f120 100644
--- a/src/mainboard/lenovo/x60/Kconfig
+++ b/src/mainboard/lenovo/x60/Kconfig
@@ -21,7 +21,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select GFXUMA
 	select BOARD_ROMSIZE_KB_2048
 	select CHANNEL_XOR_RANDOMIZATION
-	select HAVE_SMI_HANDLER
 	select HAVE_ACPI_TABLES
 	select HAVE_ACPI_RESUME
 	select USE_OPTION_TABLE
diff --git a/src/mainboard/rca/rm4100/Kconfig b/src/mainboard/rca/rm4100/Kconfig
index 5247a8c..ecbd2cc 100644
--- a/src/mainboard/rca/rm4100/Kconfig
+++ b/src/mainboard/rca/rm4100/Kconfig
@@ -10,7 +10,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_PIRQ_TABLE
 	select UDELAY_TSC
 	select BOARD_ROMSIZE_KB_1024
-	select HAVE_SMI_HANDLER
 	select GFXUMA
 
 config MAINBOARD_DIR
diff --git a/src/mainboard/roda/rk886ex/Kconfig b/src/mainboard/roda/rk886ex/Kconfig
index d4553ec..c770839 100644
--- a/src/mainboard/roda/rk886ex/Kconfig
+++ b/src/mainboard/roda/rk886ex/Kconfig
@@ -16,7 +16,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_PIRQ_TABLE
 	select HAVE_MP_TABLE
 	select MMCONF_SUPPORT
-	select HAVE_SMI_HANDLER
 	select HAVE_ACPI_TABLES
 	select HAVE_ACPI_RESUME
 	select BOARD_ROMSIZE_KB_1024
diff --git a/src/mainboard/samsung/lumpy/Kconfig b/src/mainboard/samsung/lumpy/Kconfig
index eae80fa..7cb0706 100644
--- a/src/mainboard/samsung/lumpy/Kconfig
+++ b/src/mainboard/samsung/lumpy/Kconfig
@@ -13,7 +13,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_ACPI_RESUME
 	select HAVE_ACPI_TABLES
 	select HAVE_OPTION_TABLE
-	select HAVE_SMI_HANDLER
 	select MMCONF_SUPPORT
 	select NORTHBRIDGE_INTEL_SANDYBRIDGE
 	select SOUTHBRIDGE_INTEL_BD82X6X
diff --git a/src/mainboard/samsung/stumpy/Kconfig b/src/mainboard/samsung/stumpy/Kconfig
index f16809f..4353d54 100644
--- a/src/mainboard/samsung/stumpy/Kconfig
+++ b/src/mainboard/samsung/stumpy/Kconfig
@@ -12,7 +12,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_ACPI_RESUME
 	select HAVE_ACPI_TABLES
 	select HAVE_OPTION_TABLE
-	select HAVE_SMI_HANDLER
 	select MMCONF_SUPPORT
 	select NORTHBRIDGE_INTEL_SANDYBRIDGE
 	select SOUTHBRIDGE_INTEL_BD82X6X
diff --git a/src/mainboard/thomson/ip1000/Kconfig b/src/mainboard/thomson/ip1000/Kconfig
index f9bbfa5..b1988dd 100644
--- a/src/mainboard/thomson/ip1000/Kconfig
+++ b/src/mainboard/thomson/ip1000/Kconfig
@@ -10,7 +10,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_PIRQ_TABLE
 	select UDELAY_TSC
 	select BOARD_ROMSIZE_KB_512
-	select HAVE_SMI_HANDLER
 	select GFXUMA
 
 config MAINBOARD_DIR
diff --git a/src/southbridge/intel/bd82x6x/Kconfig b/src/southbridge/intel/bd82x6x/Kconfig
index e330fb4..e5a6270 100644
--- a/src/southbridge/intel/bd82x6x/Kconfig
+++ b/src/southbridge/intel/bd82x6x/Kconfig
@@ -30,6 +30,7 @@ config SOUTH_BRIDGE_OPTIONS # dummy
 	select IOAPIC
 	select HAVE_HARD_RESET
 	select HAVE_USBDEBUG
+	select HAVE_SMI_HANDLER
 	select USE_WATCHDOG_ON_BOOT
 	select PCIEXP_ASPM
 	select PCIEXP_COMMON_CLOCK
diff --git a/src/southbridge/intel/i82801dx/Kconfig b/src/southbridge/intel/i82801dx/Kconfig
index 5d4e15a..bad9936 100644
--- a/src/southbridge/intel/i82801dx/Kconfig
+++ b/src/southbridge/intel/i82801dx/Kconfig
@@ -23,3 +23,4 @@ config SOUTHBRIDGE_INTEL_I82801DX
 	bool
 	select IOAPIC
 	select HAVE_HARD_RESET
+	select HAVE_SMI_HANDLER
diff --git a/src/southbridge/intel/i82801gx/Kconfig b/src/southbridge/intel/i82801gx/Kconfig
index 4937df7..4ce6184 100644
--- a/src/southbridge/intel/i82801gx/Kconfig
+++ b/src/southbridge/intel/i82801gx/Kconfig
@@ -23,6 +23,7 @@ config SOUTHBRIDGE_INTEL_I82801GX
 	select HAVE_HARD_RESET
 	select HAVE_USBDEBUG
 	select USE_WATCHDOG_ON_BOOT
+	select HAVE_SMI_HANDLER
 
 if SOUTHBRIDGE_INTEL_I82801GX
 
diff --git a/src/southbridge/intel/sch/Kconfig b/src/southbridge/intel/sch/Kconfig
index 32eb868..24daa79 100644
--- a/src/southbridge/intel/sch/Kconfig
+++ b/src/southbridge/intel/sch/Kconfig
@@ -21,6 +21,7 @@ config SOUTHBRIDGE_INTEL_SCH
 	bool
 	select HAVE_USBDEBUG
 	select HAVE_HARD_RESET
+	select HAVE_SMI_HANDLER
 
 if SOUTHBRIDGE_INTEL_SCH
 
diff --git a/src/southbridge/via/vt8237r/Kconfig b/src/southbridge/via/vt8237r/Kconfig
index d0a6deb..8deea92 100644
--- a/src/southbridge/via/vt8237r/Kconfig
+++ b/src/southbridge/via/vt8237r/Kconfig
@@ -22,12 +22,20 @@ config SOUTHBRIDGE_VIA_VT8237R
 	select HAVE_DEBUG_SMBUS
 	select IOAPIC
 
+if SOUTHBRIDGE_VIA_VT8237R
+
+if NORTHBRIDGE_AMD_K8 || NORTHBRIDGE_AMD_FAM10
+config SOUTH_BRIDGE_OPTIONS # dummy
+	def_bool y
+	select HAVE_SMI_HANDLER
+endif
+
 config EPIA_VT8237R_INIT
 	bool
 	default n
-	depends on SOUTHBRIDGE_VIA_VT8237R
 
 config BOOTBLOCK_SOUTHBRIDGE_INIT
 	string
 	default "southbridge/via/vt8237r/bootblock.c"
-	depends on SOUTHBRIDGE_VIA_VT8237R
+
+endif




More information about the coreboot mailing list