[coreboot] New patch to review for coreboot: c0df3bf x86/Makefile.inc: Test if the strings are equal by single equal sign

Zheng Bao (zheng.bao@amd.com) gerrit at coreboot.org
Mon Nov 12 07:27:48 CET 2012


Zheng Bao (zheng.bao at amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1817

-gerrit

commit c0df3bffb8698f078049cd4e2cdb7d37bc42b27a
Author: Zheng Bao <fishbaozi at gmail.com>
Date:   Mon Nov 12 15:48:21 2012 +0800

    x86/Makefile.inc: Test if the strings are equal by single equal sign
    
    Double equal sign like "test a == b" works. It really does, except NetBSD.
    But I haven't found any clue in the manual for the command test about "==".
    
    Change-Id: I37254cfeb688fd1092f2e549d24f8eb270f02fd8
    Signed-off-by: Zheng Bao <zheng.bao at amd.com>
    Signed-off-by: zbao <fishbaozi at gmail.com>
---
 src/arch/x86/Makefile.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc
index 868f159..e41bc26 100644
--- a/src/arch/x86/Makefile.inc
+++ b/src/arch/x86/Makefile.inc
@@ -343,7 +343,7 @@ else
 endif
 	$(NM) $@ | grep -q " [DdBb] "; if [ $$? -eq 0 ]; then \
 		echo "Forbidden global variables in romstage:"; \
-		$(NM) $@ | grep " [DdBb] "; test "$(CONFIG_CPU_AMD_AGESA)" == y; \
+		$(NM) $@ | grep " [DdBb] "; test "$(CONFIG_CPU_AMD_AGESA)" = y; \
 		else true; fi
 
 $(objcbfs)/romstage_xip.debug: $$(romstage-objs) $(objgenerated)/romstage_xip.ld




More information about the coreboot mailing list