[coreboot] Patch set updated for coreboot: dd1e5b4 SMM: Save the GNVS pointer when creating APCI tables

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Thu Nov 8 20:31:48 CET 2012


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1768

-gerrit

commit dd1e5b48cf39f9fa7bb151bb6d3104e058cf61af
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Wed Oct 3 19:20:37 2012 -0700

    SMM: Save the GNVS pointer when creating APCI tables
    
    At boot time when the ACPI tables are created and the location
    of GNVS is determined then save that address for resume time.
    
    This also sets the values of USB charging in S3/S5 to the expected
    default values for Stout/Butterfly that were not set correctly.
    
    Change-Id: I9b94b868aa6e81aced06c0262cc2697ad4faf1e6
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
---
 src/mainboard/intel/emeraldlake2/acpi_tables.c | 1 +
 src/mainboard/samsung/lumpy/acpi_tables.c      | 1 +
 src/mainboard/samsung/stumpy/acpi_tables.c     | 1 +
 3 files changed, 3 insertions(+)

diff --git a/src/mainboard/intel/emeraldlake2/acpi_tables.c b/src/mainboard/intel/emeraldlake2/acpi_tables.c
index c22dcab..6e32779 100644
--- a/src/mainboard/intel/emeraldlake2/acpi_tables.c
+++ b/src/mainboard/intel/emeraldlake2/acpi_tables.c
@@ -247,6 +247,7 @@ unsigned long write_acpi_tables(unsigned long start)
 			printk(BIOS_DEBUG, "ACPI: Patching up global NVS in "
 			     "DSDT at offset 0x%04x -> 0x%08lx\n", i, current);
 			*(u32*)(((u32)dsdt) + i) = current; // 0x92 bytes
+			acpi_save_gnvs(current);
 			break;
 		}
 	}
diff --git a/src/mainboard/samsung/lumpy/acpi_tables.c b/src/mainboard/samsung/lumpy/acpi_tables.c
index fca9c82..13e9e0f 100644
--- a/src/mainboard/samsung/lumpy/acpi_tables.c
+++ b/src/mainboard/samsung/lumpy/acpi_tables.c
@@ -244,6 +244,7 @@ unsigned long write_acpi_tables(unsigned long start)
 			printk(BIOS_DEBUG, "ACPI: Patching up global NVS in "
 			     "DSDT at offset 0x%04x -> 0x%08lx\n", i, current);
 			*(u32*)(((u32)dsdt) + i) = current; // 0x92 bytes
+			acpi_save_gnvs(current);
 			break;
 		}
 	}
diff --git a/src/mainboard/samsung/stumpy/acpi_tables.c b/src/mainboard/samsung/stumpy/acpi_tables.c
index b91e1e3..b68edcd 100644
--- a/src/mainboard/samsung/stumpy/acpi_tables.c
+++ b/src/mainboard/samsung/stumpy/acpi_tables.c
@@ -248,6 +248,7 @@ unsigned long write_acpi_tables(unsigned long start)
 			printk(BIOS_DEBUG, "ACPI: Patching up global NVS in "
 			     "DSDT at offset 0x%04x -> 0x%08lx\n", i, current);
 			*(u32*)(((u32)dsdt) + i) = current; // 0x92 bytes
+			acpi_save_gnvs(current);
 			break;
 		}
 	}




More information about the coreboot mailing list