[coreboot] Patch merged into coreboot/master: 3beb6db spi: fix erase in SMM while SPIBAR is locked

gerrit at coreboot.org gerrit at coreboot.org
Thu Nov 8 19:39:15 CET 2012


the following patch was just integrated into master:
commit 3beb6db6dda7795639d2bb8ec1a1aa3106a4c301
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Sat Sep 1 13:44:17 2012 -0700

    spi: fix erase in SMM while SPIBAR is locked
    
    The handling of write enable was not entirely correct,
    the opcode needs to be skipped when the controller is
    locked down.
    
    Addresses were not getting set properly for erase commands
    which seemed to mostly work when the previous command had
    set an address.
    
    Tested by adding events to the event log at runtime on a
    freslhy flashed device (with locked down SPI controller)
    until the log log shrink happens to ensure it does not hang:
    
    hexdump -C elog.event.kernel_clean
    00000000  01 00 00 00 ad de 00 00  00 00
    
    for x in $(seq 1 232); do
     cat elog.event.kernel_clean > /sys/firmware/gsmi/append_to_eventlog
    done
    
    mosys eventlog list | tail -6
    154 | 2012-09-01 13:54:43 | Kernel Event | Clean Shutdown
    155 | 2012-09-01 13:54:43 | Kernel Event | Clean Shutdown
    156 | 2012-09-01 13:54:43 | Kernel Event | Clean Shutdown
    157 | 2012-09-01 13:54:43 | Kernel Event | Clean Shutdown
    158 | 2012-09-01 13:54:43 | Log area cleared | 1030
    159 | 2012-09-01 13:54:43 | Kernel Event | Clean Shutdown
    
    Change-Id: I3a50dae54422a9ff37daefce3632f8bcbe4eb89f
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: http://review.coreboot.org/1717
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>

Build-Tested: build bot (Jenkins) at Thu Nov  8 07:47:01 2012, giving +1
See http://review.coreboot.org/1717 for details.

-gerrit




More information about the coreboot mailing list