[coreboot] New patch to review for coreboot: a7a0b0a Revert "libpayload: Add reset function for OHCI USB driver"

Nico Huber (nico.huber@secunet.com) gerrit at coreboot.org
Thu Nov 8 11:54:03 CET 2012

Nico Huber (nico.huber at secunet.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1806


commit a7a0b0a47a668df2125788cc3ee490b1717cbef6
Author: Nico Huber <nico.huber at secunet.com>
Date:   Thu Nov 8 11:26:09 2012 +0100

    Revert "libpayload: Add reset function for OHCI USB driver"
    This reverts commit db2c400ab852a2aae09d812b20e520ca371da35b.
    The given implementation of ohci_reset() doesn't work as expected. It
    leaves the controller in a non-functional state. Since the only place
    I can find where it's called is the end of ohci_init(), this cannot be
    what we want. I guess the original intent of ohci_reset() was to
    perform some kind of bus reset while this does a controller reset.
    Change-Id: I480407b5d5834517a8037ac5fddbdfa946d54927
    Signed-off-by: Nico Huber <nico.huber at secunet.com>
 payloads/libpayload/drivers/usb/ohci.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/payloads/libpayload/drivers/usb/ohci.c b/payloads/libpayload/drivers/usb/ohci.c
index 095eec9..d856665 100644
--- a/payloads/libpayload/drivers/usb/ohci.c
+++ b/payloads/libpayload/drivers/usb/ohci.c
@@ -49,13 +49,6 @@ static void ohci_process_done_queue(ohci_t *ohci, int spew_debug);
 static void
 ohci_reset (hci_t *controller)
-	if (controller == NULL)
-		return;
-	OHCI_INST(controller)->opreg->HcCommandStatus = HostControllerReset;
-	mdelay(2); /* wait 2ms */
-	OHCI_INST(controller)->opreg->HcControl = 0;
-	mdelay(10); /* wait 10ms */
 #ifdef USB_DEBUG

More information about the coreboot mailing list