[coreboot] New patch to review for coreboot: b9b6e65 libpayload: Take usb_poll out of usb_initialize.
Stefan Reinauer (stefan.reinauer@coreboot.org)
gerrit at coreboot.org
Wed Nov 7 00:22:07 CET 2012
Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1737
-gerrit
commit b9b6e65c6f7c0659db29460256bcfd390e9d4b0a
Author: Gabe Black <gabeblack at google.com>
Date: Wed Oct 31 15:55:16 2012 -0700
libpayload: Take usb_poll out of usb_initialize.
While it might be slightly more convenient to not have to call usb_poll
manually after calling usb_initialize, you'll still likely want to call it
before trying to use a USB device since one have have been hotplugged since
you last looked. By not calling usb_poll, usb_initialize completes quickly and
can be called unconditionally without a long delay. The delay can be put off
until later when we're sure it's necessary.
Change-Id: Ib8b1bdea996702c42d1b7021f492d9f8e174d304
Signed-off-by: Gabe Black <gabeblack at google.com>
---
payloads/libpayload/drivers/usb/usbinit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/payloads/libpayload/drivers/usb/usbinit.c b/payloads/libpayload/drivers/usb/usbinit.c
index f51783b..4419ce6 100644
--- a/payloads/libpayload/drivers/usb/usbinit.c
+++ b/payloads/libpayload/drivers/usb/usbinit.c
@@ -155,6 +155,5 @@ static void usb_scan_pci_bus(int bus)
int usb_initialize(void)
{
usb_scan_pci_bus(0);
- usb_poll();
return 0;
}
More information about the coreboot
mailing list