[coreboot] New patch to review for coreboot: b4c6c2d Fix CONFIG_ use in i8254.c

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Tue Nov 6 23:51:36 CET 2012


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1694

-gerrit

commit b4c6c2d138fa0e2552799a0d8fda4a0ab4663ead
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Tue Aug 7 14:49:01 2012 -0700

    Fix CONFIG_ use in i8254.c
    
    We always define CONFIG_ variables, even if they're not set.
    Hence, remove the check whether CONFIG_UDELAY_TIMER2 is defined
    
    Change-Id: Iefdf2389941f2cc63ae4f13ac6b213da4c96b201
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
---
 src/drivers/pc80/i8254.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/drivers/pc80/i8254.c b/src/drivers/pc80/i8254.c
index f75216d..ca993f4 100644
--- a/src/drivers/pc80/i8254.c
+++ b/src/drivers/pc80/i8254.c
@@ -35,7 +35,7 @@ void setup_i8254(void)
 	outb(0x12, TIMER1_PORT);
 }
 
-#if defined(CONFIG_UDELAY_TIMER2) &&  CONFIG_UDELAY_TIMER2
+#if CONFIG_UDELAY_TIMER2
 static void load_timer2(unsigned int ticks)
 {
         /* Set up the timer gate, turn off the speaker */




More information about the coreboot mailing list