[coreboot] New patch to review for coreboot: 150a694 Fix some issues with new "reference" toolchain

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Fri Nov 2 17:29:58 CET 2012


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1670

-gerrit

commit 150a694024149635af633946f61051248df6bdd5
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date:   Fri Nov 2 17:26:33 2012 +0100

    Fix some issues with new "reference" toolchain
    
    Unfortunately the reference tool chain was updated
    without ever even testing it on an abuild run. This
    broke a number of ports.
    
    This change gets coreboot at least compiling again
    for all supported systems.
    
    Change-Id: I92c7cbc834de6d792fdab86b75df339e2874c52e
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
---
 src/northbridge/intel/e7505/raminit.c | 2 +-
 src/southbridge/nvidia/ck804/nic.c    | 2 +-
 src/southbridge/nvidia/mcp55/nic.c    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/northbridge/intel/e7505/raminit.c b/src/northbridge/intel/e7505/raminit.c
index fd4e2d0..2f558f5 100644
--- a/src/northbridge/intel/e7505/raminit.c
+++ b/src/northbridge/intel/e7505/raminit.c
@@ -936,7 +936,7 @@ static void configure_e7501_ram_addresses(const struct mem_controller
  *
  * NOTE: All cache and stack is lost during ECC scrub loop.
  */
-static void __attribute__((always_inline))
+static inline void __attribute__((always_inline))
 		initialize_ecc(unsigned long ret_addr, unsigned long ret_addr2)
 {
 	uint16_t scrubbed = pci_read_config16(MCHDEV, MCHCFGNS) & 0x08;
diff --git a/src/southbridge/nvidia/ck804/nic.c b/src/southbridge/nvidia/ck804/nic.c
index c62728a..42f5e30 100644
--- a/src/southbridge/nvidia/ck804/nic.c
+++ b/src/southbridge/nvidia/ck804/nic.c
@@ -29,7 +29,7 @@
 
 static void nic_init(struct device *dev)
 {
-	u32 dword, old, mac_h, mac_l;
+	u32 dword, old, mac_h = 0, mac_l = 0;
 	int eeprom_valid = 0;
 	struct southbridge_nvidia_ck804_config *conf;
 	static u32 nic_index = 0;
diff --git a/src/southbridge/nvidia/mcp55/nic.c b/src/southbridge/nvidia/mcp55/nic.c
index 0521b89..4d17b42 100644
--- a/src/southbridge/nvidia/mcp55/nic.c
+++ b/src/southbridge/nvidia/mcp55/nic.c
@@ -103,7 +103,7 @@ static void phy_detect(u32 base)
 
 static void nic_init(struct device *dev)
 {
-	u32 mac_h, mac_l, base;
+	u32 mac_h = 0, mac_l = 0, base;
 	int eeprom_valid = 0;
 	struct southbridge_nvidia_mcp55_config *conf;
 	static u32 nic_index = 0;




More information about the coreboot mailing list