[coreboot] New patch to review for coreboot: fe83010 libpayload: fix UHCI timeout
Nico Huber (nico.huber@secunet.com)
gerrit at coreboot.org
Thu May 31 15:41:41 CEST 2012
Nico Huber (nico.huber at secunet.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1085
-gerrit
commit fe83010951dbf184cb5665ed375851360073d02b
Author: Mathias Krause <mathias.krause at secunet.com>
Date: Tue May 29 16:19:19 2012 +0200
libpayload: fix UHCI timeout
UHCI commands should have a timeout of 30ms, not 30s!
Change-Id: Iebcf338317164eb1e683e1de850ffab5022ca3a1
Signed-off-by: Mathias Krause <mathias.krause at secunet.com>
---
payloads/libpayload/drivers/usb/uhci.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/payloads/libpayload/drivers/usb/uhci.c b/payloads/libpayload/drivers/usb/uhci.c
index 8e6c9ed..78f7aba 100644
--- a/payloads/libpayload/drivers/usb/uhci.c
+++ b/payloads/libpayload/drivers/usb/uhci.c
@@ -267,12 +267,12 @@ uhci_stop (hci_t *controller)
static td_t *
wait_for_completed_qh (hci_t *controller, qh_t *qh)
{
- int timeout = 1000000; /* max 30 ms. */
+ int timeout = 1000; /* max 30 ms. */
void *current = GET_TD (qh->elementlinkptr);
while (((qh->elementlinkptr & FLISTP_TERMINATE) == 0) && (timeout-- > 0)) {
if (current != GET_TD (qh->elementlinkptr)) {
current = GET_TD (qh->elementlinkptr);
- timeout = 1000000;
+ timeout = 1000;
}
uhci_reg_write16(controller, USBSTS,
uhci_reg_read16(controller, USBSTS) | 0); // clear resettable registers
More information about the coreboot
mailing list