[coreboot] New patch to review for coreboot: 7772794 libpayload: Remove orphaned delay from OHCI USB driver

Nico Huber (nico.huber@secunet.com) gerrit at coreboot.org
Thu May 31 15:41:31 CEST 2012


Nico Huber (nico.huber at secunet.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1075

-gerrit

commit 77727940b54e5fe4daafa21e638951f2fb2162f2
Author: Nico Huber <nico.huber at secunet.com>
Date:   Mon May 21 14:41:49 2012 +0200

    libpayload: Remove orphaned delay from OHCI USB driver
    
    This removes a synthetic delay of 5ms from every OHCI USB command.  A delay
    here seems to be of no use and first tests have shown no glitches.
    
    Change-Id: Ie72b2d49e6734345708f04f3f7b86bacc7926108
    Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
 payloads/libpayload/drivers/usb/ohci.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/payloads/libpayload/drivers/usb/ohci.c b/payloads/libpayload/drivers/usb/ohci.c
index fa7db3a..830542e 100644
--- a/payloads/libpayload/drivers/usb/ohci.c
+++ b/payloads/libpayload/drivers/usb/ohci.c
@@ -213,7 +213,6 @@ wait_for_ed(usbdev_t *dev, ed_t *head)
 			(((td_t*)phys_to_virt(head->head_pointer & ~3))->config & TD_CC_MASK) >> TD_CC_SHIFT);
 		mdelay(1);
 	}
-	mdelay(5);
 #if 0
 	/* XXX: The following debugging code may follow invalid lists and
 	 *      cause a reboot.




More information about the coreboot mailing list