[coreboot] Patch merged into coreboot/master: d45a87a Initializer of a static member in union.

gerrit at coreboot.org gerrit at coreboot.org
Wed May 30 23:01:26 CEST 2012


the following patch was just integrated into master:
commit d45a87a4461dc78c19b9c7ab89968abf911e91a7
Author: zbao <fishbaozi at gmail.com>
Date:   Tue May 29 14:59:38 2012 +0800

    Initializer of a static member in union.
    
    It is just me or does anybody have the same build error without
    this patch?
    ------
    src/arch/x86/boot/acpigen.c: In function 'acpigen_write_empty_PTC':
    src/arch/x86/boot/acpigen.c:347:3: error: unknown field 'resv'
    specified in initializer
    src/arch/x86/boot/acpigen.c:347:3: warning: missing braces around
     initializer
    src/arch/x86/boot/acpigen.c:347:3:warning: (near initialization
     for 'addr.<anonymous>')
    -------
    
    Anyway, I believe at least this will cause warnings.
    "resv" is a member of a union, not of acpi_addr_t. So it should be
    wrapped by a brace in the initializer.
    
    Change-Id: I72624386816c987d5bb2d3a3a64c7c58eb9af389
    Signed-off-by: Zheng Bao <zheng.bao at amd.com>
    Signed-off-by: zbao <fishbaozi at gmail.com>

Build-Tested: build bot (Jenkins) at Tue May 29 07:57:18 2012, giving +1
Reviewed-By: Stefan Reinauer <stefan.reinauer at coreboot.org> at Tue May 29 19:45:05 2012, giving +2
Reviewed-By: Marc Jones <marcj303 at gmail.com> at Wed May 30 23:01:23 2012, giving +2
See http://review.coreboot.org/1056 for details.

-gerrit




More information about the coreboot mailing list