[coreboot] Patch merged into coreboot/master: 36c386f Fix the location of "Setting variable MTRR" printk.
gerrit at coreboot.org
gerrit at coreboot.org
Wed May 30 08:32:40 CEST 2012
the following patch was just integrated into master:
commit 36c386f5387d0726be59db2193edd62cb3880136
Author: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
Date: Sat May 26 00:13:22 2012 +0200
Fix the location of "Setting variable MTRR" printk.
Without that fix the debugging is harder because the person debugging
coreboot will see the following twice(note the repeated MTRR number):
Setting variable MTRR 0, base: 0MB, range: 4096MB, type WB
[...]
Setting variable MTRR 1, base: 4096MB, range: 512MB, type WB
Setting variable MTRR 1, base: 4608MB, range: 256MB, type WB
Setting variable MTRR 1, base: 3072MB, range: 1024MB, type UC
instead of the following twice:
Setting variable MTRR 0, base: 0MB, range: 4096MB, type WB
[...]
Setting variable MTRR 1, base: 3072MB, range: 1024MB, type UC
Thanks to kmalkki on #coreboot's Freenode IRC channel for the idea:
May 25 23:57:17 <kmalkki> I would add (move) that "Setting variable MTRR..." debug at the end of set_var_mtrrs()
Change-Id: I9f4b7110ba34d017a58d8cc5fb06a7b1c3d0c8aa
Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
See http://review.coreboot.org/1058 for details.
-gerrit
More information about the coreboot
mailing list