[coreboot] New patch to review for coreboot: c7e6509 Move subsystem IDs to devicetree.cb

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Thu May 24 02:07:08 CEST 2012


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1042

-gerrit

commit c7e6509905d5cb11ac611db29c55e19c12cccbda
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Tue May 15 12:36:57 2012 -0700

    Move subsystem IDs to devicetree.cb
    
    A while back coreboot was changed to read the subsystem IDs from
    devicetree.cb to allow each onboard PCI device to have its own
    subsystem id. When we originally branched, this was not the case,
    and the sandybridge/ivybridge mainboards have not been updated yet.
    Also, drop the subsystem ID from Emerald Lake 2, since it's not a
    Google device.
    
    Change-Id: Ie96fd67cd2ff65ad6ff725914e3bad843e78712e
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
---
 src/mainboard/intel/emeraldlake2/Kconfig   |    8 --------
 src/mainboard/samsung/lumpy/Kconfig        |    8 --------
 src/mainboard/samsung/lumpy/devicetree.cb  |    1 +
 src/mainboard/samsung/stumpy/Kconfig       |    8 --------
 src/mainboard/samsung/stumpy/devicetree.cb |    1 +
 5 files changed, 2 insertions(+), 24 deletions(-)

diff --git a/src/mainboard/intel/emeraldlake2/Kconfig b/src/mainboard/intel/emeraldlake2/Kconfig
index 9e4f347..873d273 100644
--- a/src/mainboard/intel/emeraldlake2/Kconfig
+++ b/src/mainboard/intel/emeraldlake2/Kconfig
@@ -43,12 +43,4 @@ config VGA_BIOS_FILE
 	string
 	default "pci8086,0166.rom"
 
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x1ae0
-
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0xc000
-
 endif # BOARD_INTEL_EMERALDLAKE2
diff --git a/src/mainboard/samsung/lumpy/Kconfig b/src/mainboard/samsung/lumpy/Kconfig
index 200edac..0835012 100644
--- a/src/mainboard/samsung/lumpy/Kconfig
+++ b/src/mainboard/samsung/lumpy/Kconfig
@@ -44,14 +44,6 @@ config VGA_BIOS_FILE
 	string
 	default "pci8086,0106.rom"
 
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x1ae0
-
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0xc000
-
 config MAINBOARD_POWER_ON_AFTER_POWER_FAIL
 	bool
 	default n
diff --git a/src/mainboard/samsung/lumpy/devicetree.cb b/src/mainboard/samsung/lumpy/devicetree.cb
index 36af1ca..3e93df4 100644
--- a/src/mainboard/samsung/lumpy/devicetree.cb
+++ b/src/mainboard/samsung/lumpy/devicetree.cb
@@ -33,6 +33,7 @@ chip northbridge/intel/sandybridge
 	end
 
 	device pci_domain 0 on
+		subsystemid 0x1ae0 0xc000 inherit
 		device pci 00.0 on end # host bridge
 		device pci 02.0 on end # vga controller
 
diff --git a/src/mainboard/samsung/stumpy/Kconfig b/src/mainboard/samsung/stumpy/Kconfig
index dda3002..18094cf 100644
--- a/src/mainboard/samsung/stumpy/Kconfig
+++ b/src/mainboard/samsung/stumpy/Kconfig
@@ -43,14 +43,6 @@ config VGA_BIOS_FILE
 	string
 	default "pci8086,0106.rom"
 
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x1ae0
-
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0xc000
-
 config MAINBOARD_POWER_ON_AFTER_POWER_FAIL
 	bool
 	default n
diff --git a/src/mainboard/samsung/stumpy/devicetree.cb b/src/mainboard/samsung/stumpy/devicetree.cb
index f10b283..b59dcb2 100644
--- a/src/mainboard/samsung/stumpy/devicetree.cb
+++ b/src/mainboard/samsung/stumpy/devicetree.cb
@@ -28,6 +28,7 @@ chip northbridge/intel/sandybridge
 	end
 
 	device pci_domain 0 on
+		subsystemid 0x1ae0 0xc000 inherit
 		device pci 00.0 on end # host bridge
 		device pci 02.0 on end # vga controller
 




More information about the coreboot mailing list