[coreboot] New patch to review for coreboot: 92e0b14 Drop CONFIG_MAX_PHYSICAL_CPUS on non-AMD boards

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Tue May 1 20:17:57 CEST 2012


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/984

-gerrit

commit 92e0b14eaf465478798f19734f31ea8e579a39f8
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Tue May 1 11:13:52 2012 -0700

    Drop CONFIG_MAX_PHYSICAL_CPUS on non-AMD boards
    
    CONFIG_MAX_PHYSICAL_CPUS is defined by quite a number of
    mainboards whithout any code actually using the variable.
    Hence, drop MAX_PHYSICAL_CPUS from Kconfig for those boards.
    
    In the long run we should drop CONFIG_MAX_PHYSICAL_CPUS use
    completely and make the code dynamic or depend on CONFIG_MAX_CPUS
    instead.
    
    Change-Id: I37dcc74d245ddba5186b96bd82220dacb6f4d323
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
---
 src/cpu/Kconfig                          |    2 ++
 src/mainboard/asus/p2b-d/Kconfig         |    4 ----
 src/mainboard/asus/p2b-ds/Kconfig        |    4 ----
 src/mainboard/getac/p470/Kconfig         |    4 ----
 src/mainboard/ibase/mb899/Kconfig        |    4 ----
 src/mainboard/intel/d945gclf/Kconfig     |    4 ----
 src/mainboard/intel/eagleheights/Kconfig |    4 ----
 src/mainboard/intel/emeraldlake2/Kconfig |    4 ----
 src/mainboard/intel/xe7501devkit/Kconfig |    4 ----
 src/mainboard/kontron/986lcd-m/Kconfig   |    4 ----
 src/mainboard/lenovo/t60/Kconfig         |    4 ----
 src/mainboard/lenovo/x60/Kconfig         |    4 ----
 src/mainboard/roda/rk886ex/Kconfig       |    4 ----
 src/mainboard/tyan/s2735/Kconfig         |    4 ----
 14 files changed, 2 insertions(+), 52 deletions(-)

diff --git a/src/cpu/Kconfig b/src/cpu/Kconfig
index ec10a97..acb9bb5 100644
--- a/src/cpu/Kconfig
+++ b/src/cpu/Kconfig
@@ -19,6 +19,8 @@ config DCACHE_RAM_GLOBAL_VAR_SIZE
 	hex
 	default 0x0
 
+# FIXME MAX_PHYSICAL_CPUS should move to AMD specific code, or better
+# yet be dropped completely.
 config MAX_PHYSICAL_CPUS
 	int
 	default 1
diff --git a/src/mainboard/asus/p2b-d/Kconfig b/src/mainboard/asus/p2b-d/Kconfig
index cb9a69a..337e3a0 100644
--- a/src/mainboard/asus/p2b-d/Kconfig
+++ b/src/mainboard/asus/p2b-d/Kconfig
@@ -49,8 +49,4 @@ config MAX_CPUS
 	int
 	default 2
 
-config MAX_PHYSICAL_CPUS
-	int
-	default 2
-
 endif # BOARD_ASUS_P2B_D
diff --git a/src/mainboard/asus/p2b-ds/Kconfig b/src/mainboard/asus/p2b-ds/Kconfig
index cd76e92..4585a22 100644
--- a/src/mainboard/asus/p2b-ds/Kconfig
+++ b/src/mainboard/asus/p2b-ds/Kconfig
@@ -49,8 +49,4 @@ config MAX_CPUS
 	int
 	default 2
 
-config MAX_PHYSICAL_CPUS
-	int
-	default 2
-
 endif # BOARD_ASUS_P2B_DS
diff --git a/src/mainboard/getac/p470/Kconfig b/src/mainboard/getac/p470/Kconfig
index 42ce0e0..b9ed04e 100644
--- a/src/mainboard/getac/p470/Kconfig
+++ b/src/mainboard/getac/p470/Kconfig
@@ -64,10 +64,6 @@ config MAX_CPUS
 	int
 	default 4
 
-config MAX_PHYSICAL_CPUS
-	int
-	default 2
-
 config VGA_BIOS_FILE
 	string
 	default "getac-pci8086,27a2.rom"
diff --git a/src/mainboard/ibase/mb899/Kconfig b/src/mainboard/ibase/mb899/Kconfig
index 58d1d99..28abf43 100644
--- a/src/mainboard/ibase/mb899/Kconfig
+++ b/src/mainboard/ibase/mb899/Kconfig
@@ -49,10 +49,6 @@ config MAX_CPUS
 	int
 	default 4
 
-config MAX_PHYSICAL_CPUS
-	int
-	default 2
-
 config VGA_BIOS_FILE
 	string
 	default "amipci_01.20"
diff --git a/src/mainboard/intel/d945gclf/Kconfig b/src/mainboard/intel/d945gclf/Kconfig
index 32ef3e1..32da387 100644
--- a/src/mainboard/intel/d945gclf/Kconfig
+++ b/src/mainboard/intel/d945gclf/Kconfig
@@ -62,8 +62,4 @@ config MAX_CPUS
 	int
 	default 4
 
-config MAX_PHYSICAL_CPUS
-	int
-	default 2
-
 endif # BOARD_INTEL_D945GCLF
diff --git a/src/mainboard/intel/eagleheights/Kconfig b/src/mainboard/intel/eagleheights/Kconfig
index 00aa1ae..7722ad2 100644
--- a/src/mainboard/intel/eagleheights/Kconfig
+++ b/src/mainboard/intel/eagleheights/Kconfig
@@ -51,8 +51,4 @@ config MAX_CPUS
 	int
 	default 4
 
-config MAX_PHYSICAL_CPUS
-	int
-	default 2
-
 endif # BOARD_INTEL_EAGLEHEIGHTS
diff --git a/src/mainboard/intel/emeraldlake2/Kconfig b/src/mainboard/intel/emeraldlake2/Kconfig
index 002ae2a..9e4f347 100644
--- a/src/mainboard/intel/emeraldlake2/Kconfig
+++ b/src/mainboard/intel/emeraldlake2/Kconfig
@@ -39,10 +39,6 @@ config MAX_CPUS
 	int
 	default 16
 
-config MAX_PHYSICAL_CPUS
-	int
-	default 8
-
 config VGA_BIOS_FILE
 	string
 	default "pci8086,0166.rom"
diff --git a/src/mainboard/intel/xe7501devkit/Kconfig b/src/mainboard/intel/xe7501devkit/Kconfig
index a743469..3f314a6 100644
--- a/src/mainboard/intel/xe7501devkit/Kconfig
+++ b/src/mainboard/intel/xe7501devkit/Kconfig
@@ -32,8 +32,4 @@ config MAX_CPUS
 	int
 	default 2
 
-config MAX_PHYSICAL_CPUS
-	int
-	default 2
-
 endif # BOARD_INTEL_XE7501DEVKIT
diff --git a/src/mainboard/kontron/986lcd-m/Kconfig b/src/mainboard/kontron/986lcd-m/Kconfig
index e50bf1f..322850e 100644
--- a/src/mainboard/kontron/986lcd-m/Kconfig
+++ b/src/mainboard/kontron/986lcd-m/Kconfig
@@ -42,10 +42,6 @@ config MAX_CPUS
 	int
 	default 4
 
-config MAX_PHYSICAL_CPUS
-	int
-	default 2
-
 config VGA_BIOS_FILE
 	string
 	default "amipci_01.20"
diff --git a/src/mainboard/lenovo/t60/Kconfig b/src/mainboard/lenovo/t60/Kconfig
index 8bb2d2d..062a459 100644
--- a/src/mainboard/lenovo/t60/Kconfig
+++ b/src/mainboard/lenovo/t60/Kconfig
@@ -52,8 +52,4 @@ config MAX_CPUS
 	int
 	default 2
 
-config MAX_PHYSICAL_CPUS
-	int
-	default 1
-
 endif
diff --git a/src/mainboard/lenovo/x60/Kconfig b/src/mainboard/lenovo/x60/Kconfig
index 3fdfe2f..d35ab03 100644
--- a/src/mainboard/lenovo/x60/Kconfig
+++ b/src/mainboard/lenovo/x60/Kconfig
@@ -53,8 +53,4 @@ config MAX_CPUS
 	int
 	default 2
 
-config MAX_PHYSICAL_CPUS
-	int
-	default 1
-
 endif
diff --git a/src/mainboard/roda/rk886ex/Kconfig b/src/mainboard/roda/rk886ex/Kconfig
index 53b475c..929e5e6 100644
--- a/src/mainboard/roda/rk886ex/Kconfig
+++ b/src/mainboard/roda/rk886ex/Kconfig
@@ -43,10 +43,6 @@ config MAX_CPUS
 	int
 	default 4
 
-config MAX_PHYSICAL_CPUS
-	int
-	default 2
-
 config MAXIMUM_SUPPORTED_FREQUENCY
 	int
 	default 400
diff --git a/src/mainboard/tyan/s2735/Kconfig b/src/mainboard/tyan/s2735/Kconfig
index 9e1b57f..f908908 100644
--- a/src/mainboard/tyan/s2735/Kconfig
+++ b/src/mainboard/tyan/s2735/Kconfig
@@ -40,8 +40,4 @@ config MAX_CPUS
 	int
 	default 4
 
-config MAX_PHYSICAL_CPUS
-	int
-	default 2
-
 endif # BOARD_TYAN_S2735




More information about the coreboot mailing list