[coreboot] New patch to review for coreboot: 2e72f8a Allow components smaller than declared size.

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Wed Mar 7 01:24:53 CET 2012

Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/751


commit 2e72f8ad4e057c8fc932902f70bc266358561020
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Wed Nov 9 14:11:26 2011 -0800

    Allow components smaller than declared size.
    idftool was failing to add the ME blobs into the output image in case
    the blob size does not exactly match the size allocated for it in the
    flashrom structure.
    It is difficult to set the field in the structure to exactly match the
    size (for some reason Intel flash tool fails to insert the correct
    size even when given the exact ME blob). On the other hand there is no
    harm in using am ME blob smaller than the allocated size, this change
    modifies the tool building the image to allow for smaller components.
    Change-Id: I1b04f90051b91157391943c9bad0eb06dd297431
    Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
 util/ifdtool/ifdtool.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c
index eb91b2c..8c1077c 100644
--- a/util/ifdtool/ifdtool.c
+++ b/util/ifdtool/ifdtool.c
@@ -334,7 +334,7 @@ void inject_region(char *filename, char *image, int size, int region_type,
 	printf("File %s is %d bytes\n", region_fname, region_size);
 	if ( (region_size > region.size) || ((region_type != 1) &&
-		(region_size != region.size))) {
+		(region_size > region.size))) {
 		fprintf(stderr, "Region %s is %d(0x%x) bytes. File is %d(0x%x)"
 				" bytes. Not injecting.\n",
 				region_name(region_type), region.size,

More information about the coreboot mailing list