[coreboot] New patch to review for coreboot: 0e9052f Increase size of the coreboot table area

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Fri Mar 2 23:02:04 CET 2012


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/704

-gerrit

commit 0e9052fc533f174373fb3b7ad7d2aa23f374f61b
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Sun Aug 14 13:52:03 2011 -0700

    Increase size of the coreboot table area
    
    Packing a device tree into the coreboot table can easily make
    the table exceed the current limit of 8KB. However, right now
    there is no error handling in place to catch that case.
    
    Increase the maximum memory usable for all tables from 64KB to
    128KB and increase the maximum coreboot table size from 8KB
    to 32KB.
    
    Change-Id: I2025bf070d0adb276c1cd610aa8402b50bdf2525
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
---
 src/arch/x86/boot/tables.c |    2 +-
 src/include/cbmem.h        |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/arch/x86/boot/tables.c b/src/arch/x86/boot/tables.c
index 29d2ec0..b7dc4fe 100644
--- a/src/arch/x86/boot/tables.c
+++ b/src/arch/x86/boot/tables.c
@@ -202,7 +202,7 @@ struct lb_memory *write_tables(void)
 	}
 #endif
 
-#define MAX_COREBOOT_TABLE_SIZE (8 * 1024)
+#define MAX_COREBOOT_TABLE_SIZE (32 * 1024)
 	post_code(0x9d);
 
 	high_table_pointer = (unsigned long)cbmem_add(CBMEM_ID_CBTABLE, MAX_COREBOOT_TABLE_SIZE);
diff --git a/src/include/cbmem.h b/src/include/cbmem.h
index 7c5ec07..9806854 100644
--- a/src/include/cbmem.h
+++ b/src/include/cbmem.h
@@ -20,8 +20,8 @@
 #ifndef _CBMEM_H_
 #define _CBMEM_H_
 
-/* Reserve 64k for ACPI and other tables */
-#define HIGH_MEMORY_DEF_SIZE	( 64 * 1024 )
+/* Reserve 128k for ACPI and other tables */
+#define HIGH_MEMORY_DEF_SIZE	( 128 * 1024 )
 extern uint64_t high_tables_base, high_tables_size;
 
 #if CONFIG_HAVE_ACPI_RESUME




More information about the coreboot mailing list