[coreboot] New patch to review for coreboot: 0c169bf mptable: initialize apic/bus arrays with ARRAY_SIZE

Sven Schnelle (svens@stackframe.org) gerrit at coreboot.org
Wed Jun 20 10:25:21 CEST 2012


Sven Schnelle (svens at stackframe.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1114

-gerrit

commit 0c169bf8c285165dd4f81630671a927233cd8430
Author: Sven Schnelle <svens at stackframe.org>
Date:   Wed Jun 20 10:23:31 2012 +0200

    mptable: initialize apic/bus arrays with ARRAY_SIZE
    
    and increase the busses size to 32, as 16 isn't enough one some
    systems (i5000 for example)
    
    Change-Id: Ie09f451dd82ac25b0de85fd47807136e01da737b
    Signed-off-by: Sven Schnelle <svens at stackframe.org>
---
 util/mptable/mptable.c |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/util/mptable/mptable.c b/util/mptable/mptable.c
index e281861..e284576 100644
--- a/util/mptable/mptable.c
+++ b/util/mptable/mptable.c
@@ -276,7 +276,7 @@ static void pnstr(uint8_t * s, int c);
 /* global data */
 int pfd;			/* physical /dev/mem fd */
 
-int busses[16];
+int busses[32];
 int apics[16];
 
 int ncpu;
@@ -787,9 +787,10 @@ static void MPConfigTableHeader(uint32_t pap)
 	}
 
 	/* initialze tables */
-	for (x = 0; x < 16; ++x) {
-		busses[x] = apics[x] = 0xff;
-	}
+	for(x = 0; x < ARRAY_SIZE(busses); x++)
+		busses[x] = UNKNOWN_BUSTYPE;
+	for(x = 0; x < ARRAY_SIZE(apics); x++)
+		apics[x] = 0xff;
 
 	ncpu = 0;
 	nbus = 0;




More information about the coreboot mailing list