[coreboot] New patch to review for coreboot: a71f045 llshell: fix build without romcc

Denis Carikli (GNUtoo@no-log.org) gerrit at coreboot.org
Thu Jun 14 15:52:08 CEST 2012


Denis Carikli (GNUtoo at no-log.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1101

-gerrit

commit a71f045e44f42a09c318bb46086616b329ffacc8
Author: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
Date:   Thu Jun 14 14:19:09 2012 +0200

    llshell: fix build without romcc
    
    Without that fix we have:
          LINK       cbfs/fallback/romstage_null.debug
      build/generated/crt0.romstage.o: In function `ramtest':
      romstage.c:(.rom.text+0x53f): undefined reference to `.Lhlt'
      collect2: ld returned 1 exit status
      make: *** [build/cbfs/"fallback"/romstage_null.debug] Error 1
    On the M4A785T-M which doesn't have CONFIG_ROMCC.
    
    Change-Id: I49eded1d18e996afe9441b85dae04ae30c760dd6
    Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
---
 src/arch/x86/llshell/ramtest.inc |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/arch/x86/llshell/ramtest.inc b/src/arch/x86/llshell/ramtest.inc
index c02cf45..49abd4a 100644
--- a/src/arch/x86/llshell/ramtest.inc
+++ b/src/arch/x86/llshell/ramtest.inc
@@ -112,8 +112,10 @@ ramtest:
 	jmp 3b
 5:
 	CONSOLE_INFO_TX_STRING($rt_toomany)
+#if CONFIG_ROMCC
 	post_code(0xf1)
 	jmp	.Lhlt
+#endif
 
 6:
 	CONSOLE_INFO_TX_STRING($rt_done)




More information about the coreboot mailing list