[coreboot] New patch to review for coreboot: 46df204 Intel i945 and sch: no memory over 4GB

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Fri Jul 27 08:09:06 CEST 2012


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1368

-gerrit

commit 46df20489fa44e61007e4b719b186ab4e4c9e675
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Fri Jul 27 08:40:14 2012 +0300

    Intel i945 and sch: no memory over 4GB
    
    No need for the test, tomk is top of low memory and always below 4GB.
    
    Change-Id: Ifc8f29268b761aa9b07b578673236a673f0c70b5
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/northbridge/intel/i945/northbridge.c |    4 ----
 src/northbridge/intel/sch/northbridge.c  |    3 ---
 2 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/src/northbridge/intel/i945/northbridge.c b/src/northbridge/intel/i945/northbridge.c
index 58e70d7..9a69823 100644
--- a/src/northbridge/intel/i945/northbridge.c
+++ b/src/northbridge/intel/i945/northbridge.c
@@ -170,10 +170,6 @@ static void pci_domain_set_resources(device_t dev)
 	/* Report the memory regions */
 	ram_resource(dev, 3, 0, 640);
 	ram_resource(dev, 4, 768, (tomk - 768));
-	if (tomk > 4 * 1024 * 1024) {
-		ram_resource(dev, 5, 4096 * 1024, tomk - 4 * 1024 * 1024);
-	}
-
 	add_fixed_resources(dev, 6);
 
 	assign_resources(dev->link_list);
diff --git a/src/northbridge/intel/sch/northbridge.c b/src/northbridge/intel/sch/northbridge.c
index 581f97c..52b688a 100644
--- a/src/northbridge/intel/sch/northbridge.c
+++ b/src/northbridge/intel/sch/northbridge.c
@@ -182,9 +182,6 @@ static void pci_domain_set_resources(device_t dev)
 	/* Report the memory regions. */
 	ram_resource(dev, 3, 0, 640);
 	ram_resource(dev, 4, 768, (tomk - 768));
-	if (tomk > 4 * 1024 * 1024)
-		ram_resource(dev, 5, 4096 * 1024, tomk - 4 * 1024 * 1024);
-
 	add_fixed_resources(dev, 6);
 
 	assign_resources(dev->link_list);




More information about the coreboot mailing list