[coreboot] Patch merged into coreboot/master: d66dc4e ELOG: Support GSMI in CPT/PPT southbridge SMI handler

gerrit at coreboot.org gerrit at coreboot.org
Thu Jul 26 20:28:39 CEST 2012

the following patch was just integrated into master:
commit d66dc4e5e6d8b4c227a78a973ba3b057824fbb22
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Sat Jun 23 17:25:29 2012 -0700

    ELOG: Support GSMI in CPT/PPT southbridge SMI handler
    In order to support the GSMI interface the SMI handler needs
    to find and use the state save area from the same CPU that
    initiated the SMI.  In this case it is a synchronous SMI
    resulting form an IO write to port 0xB2.
    To find the right CPU state save area iterate over the region
    until the "IO Misc Info" field reports the expected value and
    then proceed to use that state save area.
    This is needed because the coreboot SMI handler only executes on
    one core, and that core is non-deterministic.  It is likely that
    the core executing the C SMM handler is not the same one that
    actually did the IO write to 0xB2 and generated the SMI.
    The GSMI parameter buffer is passed as a pointer to EBX in the
    tate save area, and the GSMI command is extracted from EAX before
    it is used as the return value.
    This interface is tested by enabling CONFIG_GOOGLE_GSMI in the
    kernel and generating events and verifying that they end up
    in the event log.
    159 | 2012-06-23 16:22:45 | Kernl Event | Clean Shutdown
    184 | 2012-06-23 17:14:05 | Kernl Event | Oops
    185 | 2012-06-23 17:14:05 | Kernl Event | Panic
    Change-Id: Ic121ea69e9f50c88467c435e095c3e3629989806
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>

Build-Tested: build bot (Jenkins) at Tue Jul 24 17:38:21 2012, giving +1
Reviewed-By: Ronald G. Minnich <rminnich at gmail.com> at Thu Jul 26 20:28:37 2012, giving +2
See http://review.coreboot.org/1317 for details.


More information about the coreboot mailing list