[coreboot] New patch to review for coreboot: 96e5b66 AMD Family 15tn: Set the default return value as AGESA_SUCCESS instead of TRUE

Zheng Bao (zheng.bao@amd.com) gerrit at coreboot.org
Tue Jul 24 10:21:55 CEST 2012

Zheng Bao (zheng.bao at amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1350


commit 96e5b66538e4ab0e38057212e25002070d77531e
Author: zbao <fishbaozi at gmail.com>
Date:   Tue Jul 24 17:58:30 2012 +0800

    AMD Family 15tn: Set the default return value as AGESA_SUCCESS instead of TRUE
    The default return value should be AGESA_SUCCESS, which is zero. If it was set as TRUE,
    the AGESA wrapper would think it was AGESA_UNSUPPORTED. That would make no sense. And it
    would produce ASSERT warning in AGESA wrapper.
    On my parmer board, with Engine sample processor, it can not create the correct DMI table.
    Routine initlate will return AGESS_ERROR.
    ------Serial message---------
    ASSERTION FAILED: file 'src/mainboard/amd/parmer/agesawrapper.c',  line 427
    DmiTable:100123c3, AcpiPstatein: 10010126, AcpiSrat:0,AcpiSlit:0, Mce:100111ba, Cmc:1001127c,Alib:1001ccd4, AcpiIvrs:0 in agesawrapper_amdinitlate
    agesawrapper_amdinitlate failed: 5
    I believe the processor with acceptable name string will create the right DMI.
    Change-Id: Ie86955cf9affffc964a7c9f4a2c63077ef2030de
    Signed-off-by: Zheng Bao <zheng.bao at amd.com>
    Signed-off-by: zbao <fishbaozi at gmail.com>
 .../amd/agesa/f15tn/Proc/CPU/Feature/cpuDmi.c      |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Feature/cpuDmi.c b/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Feature/cpuDmi.c
index 23fd79f..2e7d905 100644
--- a/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Feature/cpuDmi.c
+++ b/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Feature/cpuDmi.c
@@ -245,7 +245,7 @@ GetDmiInfoMain (
   CPU_GET_MEM_INFO CpuGetMemInfo;
   MsrData = 0;
-  Flag = TRUE;
   ProcData = NULL;
   MemInfo = NULL;
   DmiBufferPtr = *DmiTable;
@@ -473,7 +473,7 @@ GetType4Type7Info (
-  Flag = TRUE;
   DmiBufferPtr = (DMI_INFO *) ApExeParams->RelatedDataBlock;
   GetLogicalIdOfCurrentCore (&LogicalID, &ApExeParams->StdHeader);

More information about the coreboot mailing list