[coreboot] New patch to review for coreboot: 13b585b Drop leading spaces from CPU name string

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Tue Jul 24 00:12:18 CEST 2012


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1298

-gerrit

commit 13b585b977fa3e14f3b77a8c7ecdacb4e693b066
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Mon Jun 18 15:48:34 2012 -0700

    Drop leading spaces from CPU name string
    
    This is as per Intel's suggestion on how to display their name strings.
    
    Change-Id: Ie82341305e58baa8041e50a61a11b395fa7d9582
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
---
 .../intel/sandybridge/report_platform.c            |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/northbridge/intel/sandybridge/report_platform.c b/src/northbridge/intel/sandybridge/report_platform.c
index 18dffc2..bc88a89 100644
--- a/src/northbridge/intel/sandybridge/report_platform.c
+++ b/src/northbridge/intel/sandybridge/report_platform.c
@@ -29,7 +29,7 @@ static void report_cpu_info(void)
 {
 	struct cpuid_result cpuidr;
 	u32 i, index;
-	char cpu_string[50]; /* 48 bytes are reported */
+	char cpu_string[50], *cpu_name = cpu_string; /* 48 bytes are reported */
 	int vt, txt, aes;
 	const char *mode[] = {"NOT ", ""};
 
@@ -47,8 +47,12 @@ static void report_cpu_info(void)
 			*p++ = cpuidr.edx;
 		}
 	}
+	/* Skip leading spaces in CPU name string */
+	while (cpu_name[0] == ' ')
+		cpu_name++;
+
 	cpuidr = cpuid(1);
-	printk(BIOS_DEBUG, "CPU id(%x): %s\n", cpuidr.eax, cpu_string);
+	printk(BIOS_DEBUG, "CPU id(%x): %s\n", cpuidr.eax, cpu_name);
 	aes = (cpuidr.ecx & (1 << 25)) ? 1 : 0;
 	txt = (cpuidr.ecx & (1 << 6)) ? 1 : 0;
 	vt = (cpuidr.ecx & (1 << 5)) ? 1 : 0;




More information about the coreboot mailing list