[coreboot] New patch to review for coreboot: 295cc98 Fix function generating GPIO state based vector

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Mon Jul 23 23:21:13 CEST 2012


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1291

-gerrit

commit 295cc9865b194e5cfe126d6f7fd56187078325dc
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Tue Jun 19 04:56:24 2012 +0000

    Fix function generating GPIO state based vector
    
    The function was too eager shifting stuff around, this change corrects
    the problem.
    
    Change-Id: I4c13dbe86cb627835dae05bb74af9867c28e143d
    Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
---
 src/southbridge/intel/bd82x6x/gpio.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/southbridge/intel/bd82x6x/gpio.c b/src/southbridge/intel/bd82x6x/gpio.c
index 2ba34ea..25eda9a 100644
--- a/src/southbridge/intel/bd82x6x/gpio.c
+++ b/src/southbridge/intel/bd82x6x/gpio.c
@@ -93,7 +93,6 @@ unsigned get_gpios(const int *gpio_num_array)
 
 	while (bitmask &&
 	       ((gpio = *gpio_num_array++) != -1)) {
-		vector <<= 1;
 		if (get_gpio(gpio))
 			vector |= bitmask;
 		bitmask <<= 1;




More information about the coreboot mailing list