[coreboot] New patch to review for coreboot: e5ef86a Add correct bios callout into read event routine

Zheng Bao (zheng.bao@amd.com) gerrit at coreboot.org
Mon Jul 23 12:15:48 CEST 2012


Zheng Bao (zheng.bao at amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1266

-gerrit

commit e5ef86aa853de415e2254db14d11d9c8ab80332f
Author: zbao <fishbaozi at gmail.com>
Date:   Mon Jul 23 19:57:43 2012 +0800

    Add correct bios callout into read event routine
    
    Read event routine didn't get the correct BIOS callout. So it could not get
    the heap address. Then it would creat many warning in serial port.
    
    Change-Id: Ia35601bda1579c7f726ed767d7be78713ac185d2
    Signed-off-by: Zheng Bao <zheng.bao at amd.com>
    Signed-off-by: zbao <fishbaozi at gmail.com>
---
 src/mainboard/amd/parmer/agesawrapper.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mainboard/amd/parmer/agesawrapper.c b/src/mainboard/amd/parmer/agesawrapper.c
index ff36750..6f44d46 100644
--- a/src/mainboard/amd/parmer/agesawrapper.c
+++ b/src/mainboard/amd/parmer/agesawrapper.c
@@ -423,7 +423,7 @@ agesawrapper_amdinitlate (
 	Status = AmdInitLate(AmdLateParams);
 	/* CDIT table is not created. */
 	if (Status != AGESA_SUCCESS) {
-		/* agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus); */
+		agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus);
 		ASSERT(Status == AGESA_SUCCESS);
 	}
 
@@ -752,7 +752,7 @@ agesawrapper_amdreadeventlog (
 		       &(AmdEventParams.StdHeader));
 
 	AmdEventParams.StdHeader.AltImageBasePtr = 0;
-	AmdEventParams.StdHeader.CalloutPtr = NULL;
+	AmdEventParams.StdHeader.CalloutPtr = (CALLOUT_ENTRY) &GetBiosCallout;
 	AmdEventParams.StdHeader.Func = 0;
 	AmdEventParams.StdHeader.ImageBasePtr = 0;
 	AmdEventParams.StdHeader.HeapStatus = HeapStatus;




More information about the coreboot mailing list