[coreboot] New patch to review for coreboot: ab4a9de i5000: reset system if raminit fails

Sven Schnelle (svens@stackframe.org) gerrit at coreboot.org
Mon Jul 9 10:44:07 CEST 2012

Sven Schnelle (svens at stackframe.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1191


commit ab4a9de63ff25d29eae30263049ddc9d2dd26549
Author: Sven Schnelle <svens at stackframe.org>
Date:   Fri Jul 6 08:58:11 2012 +0200

    i5000: reset system if raminit fails
    Don't stop if RAM init fails at first try. It's better to restart
    and try again instead of failing on the first try if the second
    try would have worked.
    Change-Id: Ib5660265d5b10a01588f2e4022dac2ee34f2c6d0
    Signed-off-by: Sven Schnelle <svens at stackframe.org>
 src/northbridge/intel/i5000/raminit.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/northbridge/intel/i5000/raminit.c b/src/northbridge/intel/i5000/raminit.c
index 139a33c..841e809 100644
--- a/src/northbridge/intel/i5000/raminit.c
+++ b/src/northbridge/intel/i5000/raminit.c
@@ -1521,7 +1521,7 @@ static void i5000_try_restart(const char *msg)
 	printk(BIOS_INFO, msg);
-//	outb(0x06, 0xcf9);
+	outb(0x06, 0xcf9);
 	for(;;) asm volatile("hlt");

More information about the coreboot mailing list