[coreboot] New patch to review for coreboot: a071c33 Fix AMD S3 block generator on Cygwin

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Tue Jul 3 18:09:45 CEST 2012

Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1164


commit a071c337b4129b84db56f162dbc12f86f82389f9
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Tue Jul 3 18:07:04 2012 +0200

    Fix AMD S3 block generator on Cygwin
    awk on Cygwin created the UTF-8 value for the 0xff code point,
    which makes it two bytes wide. This broke the build.
    Change-Id: I4937ae7ce1136ba7a76d05b42f9dd2771203175d
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
 src/southbridge/amd/Makefile.inc |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/southbridge/amd/Makefile.inc b/src/southbridge/amd/Makefile.inc
index d7b5645..9bc58cd 100644
--- a/src/southbridge/amd/Makefile.inc
+++ b/src/southbridge/amd/Makefile.inc
@@ -20,7 +20,8 @@ ifeq ($(CONFIG_CPU_AMD_AGESA), y)
 	echo "    S3 NVRAM   0xffff0000 (S3 storage area)"
-	awk 'BEGIN {for (i=0; i<20480; i++) {printf "%c", 255}}' > $@.tmp
+	# force C locale, so cygwin awk doesn't try to interpret the 0xff below as UTF-8 (or worse)
+	LC_ALL=C awk 'BEGIN {for (i=0; i<20480; i++) {printf "%c", 255}}' > $@.tmp
 	mv $@.tmp $@
 cbfs-files-y += s3nv

More information about the coreboot mailing list