[coreboot] New patch to review for coreboot: 42dc925 dumpmmcr: fixed compilation warnings

Paul Menzel paulepanter at users.sourceforge.net
Thu Jan 26 09:03:42 CET 2012

Dear Vikram,

thank you for your work and the patch.

Am Donnerstag, den 26.01.2012, 07:42 +0100 schrieb Vikram Narayanan:
> Vikram Narayanan (vikram186 at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/582
> -gerrit
> commit 42dc925d2d86524e57ef29eef1b130e4f0e9d7a3
> Author: Vikram Narayanan <vikram186 at gmail.com>
> Date:   Wed Jan 25 17:44:20 2012 +0530
>     dumpmmcr: fixed compilation warnings
>     Fixes compilation warnings in printf

instead of almost duplicating the commit summary in the body could you
merge both and maybe paste the warning into the commit message.

    dumpmmcr: Fix compilation warnings in printf

    • cf. `man 3 printf`

You should be able to use `git commit --amend` to update the commit
message. That would be awesome.
>     Change-Id: Ib78937a3e1c1eecf884bde0860594cbdb574f1fe
>     Signed-off-by: Vikram Narayanan <vikram186 at gmail.com>
> ---
>  util/dumpmmcr/dumpmmcr.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20120126/c7bca69b/attachment.sig>

More information about the coreboot mailing list